From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0417C2D0E4 for ; Fri, 27 Nov 2020 10:32:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D12B420795 for ; Fri, 27 Nov 2020 10:32:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RTUd4sAb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D12B420795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kib3h-0004Hp-7v for qemu-devel@archiver.kernel.org; Fri, 27 Nov 2020 05:32:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kib2s-0003lp-0r for qemu-devel@nongnu.org; Fri, 27 Nov 2020 05:32:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kib2o-0003Wg-En for qemu-devel@nongnu.org; Fri, 27 Nov 2020 05:32:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606473120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6SIV8MND6a/z4GEKZ1IpgSxo1LoFGfsSRe1SaKSmHus=; b=RTUd4sAbVBmvFdRNw7QSVyRimld9J1xtGDyE+2LtiJoJMc9FCCz+jfnN6d9Qv+LMd4IJGL 15Ob7VlZTVKeACH6QO3fQX6OAmfH3WjlNwW5G2Q5cl83hzsG8YandoVsQdKoDVg4asnari FCibXF6oPUZVVQBOZXqUw2IUN5O5AmQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-449-ncoUkmOJM6iiwrWUN9hnCg-1; Fri, 27 Nov 2020 05:31:58 -0500 X-MC-Unique: ncoUkmOJM6iiwrWUN9hnCg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE808803F62 for ; Fri, 27 Nov 2020 10:31:57 +0000 (UTC) Received: from localhost (unknown [10.40.208.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9ADAC5D6D1; Fri, 27 Nov 2020 10:31:56 +0000 (UTC) Date: Fri, 27 Nov 2020 11:31:54 +0100 From: Igor Mammedov To: Paolo Bonzini Subject: Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board Message-ID: <20201127113154.1c9ef2c6@redhat.com> In-Reply-To: <8866f216-911b-2803-4b15-0e794c4c71e1@redhat.com> References: <20201123141435.2726558-1-pbonzini@redhat.com> <20201123141435.2726558-14-pbonzini@redhat.com> <20201126181036.3ff5d605@redhat.com> <8866f216-911b-2803-4b15-0e794c4c71e1@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 27 Nov 2020 06:03:43 +0100 Paolo Bonzini wrote: > On 26/11/20 18:10, Igor Mammedov wrote: > > On Mon, 23 Nov 2020 09:14:12 -0500 > > Paolo Bonzini wrote: > > > >> Move more sane parts of the huge qemu_init function out of it. > >> > >> Signed-off-by: Paolo Bonzini > >> --- > >> softmmu/vl.c | 12 +++++------- > >> 1 file changed, 5 insertions(+), 7 deletions(-) > >> > >> diff --git a/softmmu/vl.c b/softmmu/vl.c > >> index ab08a0290c..5d68cf828c 100644 > >> --- a/softmmu/vl.c > >> +++ b/softmmu/vl.c > >> @@ -3070,6 +3070,11 @@ static void qemu_init_board(void) > >> { > >> MachineClass *machine_class = MACHINE_GET_CLASS(current_machine); > >> > >> + if (semihosting_enabled() && !semihosting_get_argc() && current_machine->kernel_filename) { > >> + /* fall back to the -kernel/-append */ > >> + semihosting_arg_fallback(current_machine->kernel_filename, current_machine->kernel_cmdline); > >> + } > > > > it doesn't seem to depend on anything that warrants calling it this late. > > Yes, calling it around machine initialization time is also a > possibility. I just wanted to get rid of it in code that I'm actually > looking at. :) I'd prefer it being moved close to CLI parsing, in a place where other _early call go. We probably want qemu_init_board() being clear of not really needed clutter. > > Paolo > > > > >> if (machine_class->default_ram_id && current_machine->ram_size && > >> numa_uses_legacy_mem() && !current_machine->ram_memdev_id) { > >> create_default_memdev(current_machine, mem_path); > >> @@ -4385,13 +4390,6 @@ void qemu_init(int argc, char **argv, char **envp) > >> boot_order = machine_class->default_boot_order; > >> } > >> > >> - if (semihosting_enabled() && !semihosting_get_argc()) { > >> - const char *kernel_filename = qemu_opt_get(machine_opts, "kernel"); > >> - const char *kernel_cmdline = qemu_opt_get(machine_opts, "append"); > >> - /* fall back to the -kernel/-append */ > >> - semihosting_arg_fallback(kernel_filename, kernel_cmdline); > >> - } > > > > Can we move this hunk as is to somewhere around qemu_maybe_daemonize() time? > > > > > >> if (net_init_clients(&err) < 0) { > >> error_report_err(err); > >> exit(1); > > >