From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F37C64E75 for ; Fri, 27 Nov 2020 12:14:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 685E2208D5 for ; Fri, 27 Nov 2020 12:14:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ascafPGL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 685E2208D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiceI-0005ml-5N for qemu-devel@archiver.kernel.org; Fri, 27 Nov 2020 07:14:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiccR-0004Zz-8r for qemu-devel@nongnu.org; Fri, 27 Nov 2020 07:12:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55771) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiccO-0006rZ-DQ for qemu-devel@nongnu.org; Fri, 27 Nov 2020 07:12:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606479171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nhxa//sH0uuV5WWwTy/CDbrPw/d4fiVM8euXuhrZRYY=; b=ascafPGLoCgYsqjRzYe98LPPpt9MUndUgrWDt+a5B+Jh/TFzlnpqP0bYFEuX5FH0FYRHGX qDOlhY2QngLpgtoOOu5DZsmet81ESr9MF8Ek9ETOuLzooCIHUa2zGRspbVq09N/2Jxax31 gYjztuie7gxGJoTYhQd+394SHirbmmU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-iCQjKfJpOQOVKyhc5Yv1NA-1; Fri, 27 Nov 2020 07:12:49 -0500 X-MC-Unique: iCQjKfJpOQOVKyhc5Yv1NA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 019711005D5E for ; Fri, 27 Nov 2020 12:12:49 +0000 (UTC) Received: from localhost (unknown [10.40.208.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id D26AA10023AC; Fri, 27 Nov 2020 12:12:47 +0000 (UTC) Date: Fri, 27 Nov 2020 13:12:45 +0100 From: Igor Mammedov To: Paolo Bonzini Subject: Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board Message-ID: <20201127131245.60702c6b@redhat.com> In-Reply-To: <70f2f8cc-0b5c-72e4-434b-35197c70809b@redhat.com> References: <20201123141435.2726558-1-pbonzini@redhat.com> <20201123141435.2726558-14-pbonzini@redhat.com> <20201126181036.3ff5d605@redhat.com> <8866f216-911b-2803-4b15-0e794c4c71e1@redhat.com> <20201127113154.1c9ef2c6@redhat.com> <70f2f8cc-0b5c-72e4-434b-35197c70809b@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 27 Nov 2020 12:22:51 +0100 Paolo Bonzini wrote: > On 27/11/20 11:31, Igor Mammedov wrote: > >> Yes, calling it around machine initialization time is also a > >> possibility. I just wanted to get rid of it in code that I'm actually > >> looking at.:) > > I'd prefer it being moved close to CLI parsing, > > in a place where other _early call go. > > > > We probably want qemu_init_board() being clear of not really needed clutter. > > > > Fair enough, I'd put -semihosting-config in the same bucket as > -m/-boot/-smp (machine configuration that isn't in -M) so I'll move it > together with them. it might be machine code, but I didn't see anything that depends on machine in there that's why I've suggested to move it right after we parse CLI options (i.e. as early as possible) to keep the rest of code cleaner > > Paolo >