From: Kevin Wolf <kwolf@redhat.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] python 3.5 compatibility
Date: Mon, 30 Nov 2020 10:44:54 +0100 [thread overview]
Message-ID: <20201130094454.GA5078@merkur.fritz.box> (raw)
In-Reply-To: <20201127183619.8958-1-info@metux.net>
Am 27.11.2020 um 19:36 hat Enrico Weigelt, metux IT consult geschrieben:
> Several stable distros are still on python-3.5, so qemu cannot be
> built there, w/o backporting the whole python stack. In order to
> make qemu build there, make it running w/ python-3.5. The changes
> are mostly removing the new type annotations (which, IMHO, just
> serve for documentation purpose)
While type hints are valuable documentation, they are more than just
that. They help to find and prevent avoidable bugs in the code. We are
actively in the process of adding them to everything in the QAPI
generator to improve maintainability rather than removing them.
Kevin
> and replacing f-strings by classic
> string formatting.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> configure | 4 +--
> scripts/block-coroutine-wrapper.py | 56 ++++++++++++++++++--------------------
> scripts/qapi/commands.py | 2 +-
> scripts/qapi/common.py | 2 +-
> scripts/qapi/events.py | 2 +-
> scripts/qapi/gen.py | 10 +++----
> scripts/qapi/main.py | 6 ++--
> scripts/qapi/schema.py | 2 +-
> scripts/qapi/source.py | 10 +++----
> 9 files changed, 46 insertions(+), 48 deletions(-)
next prev parent reply other threads:[~2020-11-30 9:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 18:36 [PATCH] python 3.5 compatibility Enrico Weigelt, metux IT consult
2020-11-27 19:15 ` Peter Maydell
2020-11-30 18:27 ` Enrico Weigelt, metux IT consult
2020-12-01 6:33 ` Markus Armbruster
2020-12-01 15:59 ` Enrico Weigelt, metux IT consult
2020-12-01 16:39 ` Daniel P. Berrangé
2020-12-01 7:32 ` Marc-André Lureau
2020-11-30 9:44 ` Kevin Wolf [this message]
2020-11-30 18:30 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130094454.GA5078@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=info@metux.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).