From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57864C64E8A for ; Mon, 30 Nov 2020 10:27:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6381A20708 for ; Mon, 30 Nov 2020 10:27:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OSLkJGmj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6381A20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjgPK-0005CD-0x for qemu-devel@archiver.kernel.org; Mon, 30 Nov 2020 05:27:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjgNO-0004Cm-Px for qemu-devel@nongnu.org; Mon, 30 Nov 2020 05:25:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kjgNM-0003SQ-5R for qemu-devel@nongnu.org; Mon, 30 Nov 2020 05:25:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606731940; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WyCLL+/7Qqd39ePt3TXqX0Y3RQuylSGw67vzQWoNWfA=; b=OSLkJGmjLgiaM3YFX6V/zKeF1/DWqBeNaq4pEcBI9IHcrB1/ixMkx09HhlhCYPazksLox+ wmUijDUg4oqUR6Nx3WFVZ4wdL83ugKgo/QqJzrhmwoHDqOSjQgT0aWg/CaRhkUUBGt2LnH tJtuQSp4VVx8+yxnULmv9FkOW0NJMqM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-mm57XRSqNaCQ3OE2NZMYEw-1; Mon, 30 Nov 2020 05:25:35 -0500 X-MC-Unique: mm57XRSqNaCQ3OE2NZMYEw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98D33802B4C; Mon, 30 Nov 2020 10:25:34 +0000 (UTC) Received: from redhat.com (ovpn-114-242.ams2.redhat.com [10.36.114.242]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D48215D6A8; Mon, 30 Nov 2020 10:25:25 +0000 (UTC) Date: Mon, 30 Nov 2020 10:25:22 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Subject: Re: [RFC PATCH-for-5.2] gitlab-ci: Do not automatically run Avocado integration tests anymore Message-ID: <20201130102522.GB2039965@redhat.com> References: <20201127174110.1932671-1-philmd@redhat.com> <9157dce0-4f5d-3f1e-ce75-3e9da9252203@redhat.com> <5a854d27-ac95-76ff-5014-be80239de796@redhat.com> MIME-Version: 1.0 In-Reply-To: <5a854d27-ac95-76ff-5014-be80239de796@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.496, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: virt-ci-maint-team@redhat.com, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Willian Rampazzo , Cleber Rosa , Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Nov 30, 2020 at 10:03:35AM +0100, Thomas Huth wrote: > On 27/11/2020 19.46, Philippe Mathieu-Daudé wrote: > > On 11/27/20 7:29 PM, Thomas Huth wrote: > >> On 27/11/2020 18.57, Philippe Mathieu-Daudé wrote: > >>> On 11/27/20 6:47 PM, Thomas Huth wrote: > >>>> On 27/11/2020 18.41, Philippe Mathieu-Daudé wrote: > >>>>> We lately realized that the Avocado framework was not designed > >>>>> to be regularly run on CI environments. Therefore, as of 5.2 > >>>>> we deprecate the gitlab-ci jobs using Avocado. To not disrupt > >>>>> current users, it is possible to keep the current behavior by > >>>>> setting the QEMU_CI_INTEGRATION_JOBS_PRE_5_2_RELEASE variable > >>>>> (see [*]). > >>>>> From now on, using these jobs (or adding new tests to them) > >>>>> is strongly discouraged. > >>>>> > >>>>> Tests based on Avocado will be ported to new job schemes during > >>>>> the next releases, with better documentation and templates. > >>>> > >>>> Why should we disable the jobs by default as long as there is no replacement > >>>> available yet? > >>> > >>> Why keep it enabled if it is failing randomly > >> > >> We can still disable single jobs if they are not stable, but that's no > >> reason to disable all of them by default, is it? > >> > >>> if images hardcoded > >>> in tests are being removed from public servers, etc...? > >> > >> That's independent from Avocado, you'll always have that problem if you want > >> to test with external images, unless you mirror them into a repository on > >> the same server (ie. gitlab), which, however, might not always be possible... > >> > >>> They are not disabled, they are still runnable manually or setting > >>> QEMU_CI_INTEGRATION_JOBS_PRE_5_2_RELEASE... > >> > >> And who do you think is going to set that variable? Hardly anybody, I guess. > > > > Does that mean nobody cares about these tests? > > It's like with all the other tests: Most of the people do not really care > about them (if they are not the author of a test) unless the test fails > during "make check" / the gating CI of Peter. So IMHO the right way to go is > to finally get these in the gating CI, otherwise, if you now even disable > them in the gitlab-CI by default, they will bitrot completely. That people don't care, and ignore it until Peter hits the failure during merge is a tragedy of the commons in itself. I think we need to set expectations that caring about tests is a key part of every contributor's responsibility, with subsystem maintainers leading by example: https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg04897.html We do need tests to be reliable though when we're treating them as gating. Hiding unreliable tests behind an env variable you have to opt-in to setting is not going to help that. IMHO unreliable tests should be just disabled entirely. If someone genuinely does care about the test then they can fix it and re-enable it at the same time. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|