From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48894C64E7A for ; Tue, 1 Dec 2020 10:30:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64EBF2080A for ; Tue, 1 Dec 2020 10:30:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NuUFUsNP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64EBF2080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kk2vr-0000FX-Ry for qemu-devel@archiver.kernel.org; Tue, 01 Dec 2020 05:30:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kk2uk-0008EU-5Q for qemu-devel@nongnu.org; Tue, 01 Dec 2020 05:29:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:45386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kk2uh-0001ro-Tj for qemu-devel@nongnu.org; Tue, 01 Dec 2020 05:29:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606818577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=29GiPUcHG6BVBGYkaOUZZRIkGMNDwmmK7/VLgAbdXA8=; b=NuUFUsNPixy2v6L7+W+wneSU41QGbCKP8T8rsxoN6oFpZE4ROQ49lxjRElezB5QLOgZgwc sThgxM98ALFyr+iRpbc7KhnxvNiiQdFO2eJUzaN9pBvzJfOYJAqcJUrGbzgk1VE2wgzAZX Wzs1UeEftVJlAKN1Eu00KQS1X/dUv0o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-fsoSiNuHMZKSDEHjItVKpQ-1; Tue, 01 Dec 2020 05:29:34 -0500 X-MC-Unique: fsoSiNuHMZKSDEHjItVKpQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0D475708F; Tue, 1 Dec 2020 10:29:33 +0000 (UTC) Received: from work-vm (ovpn-115-1.ams2.redhat.com [10.36.115.1]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E6B76F439; Tue, 1 Dec 2020 10:29:32 +0000 (UTC) Date: Tue, 1 Dec 2020 10:29:30 +0000 From: "Dr. David Alan Gilbert" To: Peter Maydell Subject: Re: [PATCH] hmp-commands.hx: List abbreviation after command for cont, quit, print Message-ID: <20201201102930.GB4338@work-vm> References: <20201121151711.20783-1-peter.maydell@linaro.org> MIME-Version: 1.0 In-Reply-To: <20201121151711.20783-1-peter.maydell@linaro.org> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.496, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Peter Maydell (peter.maydell@linaro.org) wrote: > We have four HMP commands which have a single-character abbreviated > version: cont ('c'), quit ('q'), print ('p') and help ('h'). For > cont, quit and print, we list the abbreviation first in the help > documentation and the command name. This has the odd effect that in > the full 'help' command list these commands end up sorted out of > alphabetical order (they end up after all the other commands that > start with the same letter). As it happens, the only place this > currently changes the order is for 'cont'. > > Abbreviation first is also not a very logical order, and it doesn't > match what we use for 'help' (which is 'help|?'). Put the full > command name first in both the help text and the .name field for > cont, quit and print. > > Fixes: https://bugs.launchpad.net/qemu/+bug/1614609 > Signed-off-by: Peter Maydell Thanks; I like old bugs being fixed! Reviewed-by: Dr. David Alan Gilbert > --- > hmp-commands.hx | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index ff2d7aa8f3e..15a14ed4c7f 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -40,7 +40,7 @@ SRST > ERST > > { > - .name = "q|quit", > + .name = "quit|q", > .args_type = "", > .params = "", > .help = "quit the emulator", > @@ -48,7 +48,7 @@ ERST > }, > > SRST > -``q`` or ``quit`` > +``quit`` or ``q`` > Quit the emulator. > ERST > > @@ -400,7 +400,7 @@ SRST > ERST > > { > - .name = "c|cont", > + .name = "cont|c", > .args_type = "", > .params = "", > .help = "resume emulation", > @@ -408,7 +408,7 @@ ERST > }, > > SRST > -``c`` or ``cont`` > +``cont`` or ``c`` > Resume emulation. > ERST > > @@ -553,7 +553,7 @@ SRST > ERST > > { > - .name = "p|print", > + .name = "print|p", > .args_type = "fmt:/,val:l", > .params = "/fmt expr", > .help = "print expression value (use $reg for CPU register access)", > @@ -561,7 +561,7 @@ ERST > }, > > SRST > -``p`` or ``print/``\ *fmt* *expr* > +``print`` or ``p/``\ *fmt* *expr* > Print expression value. Only the *format* part of *fmt* is > used. > ERST > -- > 2.20.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK