From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Coiby Xu" <Coiby.Xu@gmail.com>,
"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>
Subject: [PATCH v2 0/4] vhost-user: avoid g_return_val_if() in get/set_config()
Date: Wed, 2 Dec 2020 15:26:07 +0000 [thread overview]
Message-ID: <20201202152611.677753-1-stefanha@redhat.com> (raw)
v2:
* Print errors [Marc-André]
Markus Armbruster pointed out that g_return_val_if() is meant for programming
errors. It must not be used for input validation since it can be compiled out.
Use explicit if statements instead.
This patch series converts vhost-user device backends that use
g_return_val_if() in get/set_config().
Stefan Hajnoczi (4):
contrib/vhost-user-blk: avoid g_return_val_if() input validation
contrib/vhost-user-gpu: avoid g_return_val_if() input validation
contrib/vhost-user-input: avoid g_return_val_if() input validation
block/export: avoid g_return_val_if() input validation
block/export/vhost-user-blk-server.c | 6 +++++-
contrib/vhost-user-blk/vhost-user-blk.c | 6 +++++-
contrib/vhost-user-gpu/vhost-user-gpu.c | 6 +++++-
contrib/vhost-user-input/main.c | 6 +++++-
4 files changed, 20 insertions(+), 4 deletions(-)
--
2.28.0
next reply other threads:[~2020-12-02 15:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 15:26 Stefan Hajnoczi [this message]
2020-12-02 15:26 ` [PATCH v2 1/4] contrib/vhost-user-blk: avoid g_return_val_if() input validation Stefan Hajnoczi
2020-12-02 15:49 ` Marc-André Lureau
2020-12-02 15:54 ` Raphael Norwitz
2020-12-02 15:55 ` Philippe Mathieu-Daudé
2020-12-02 15:26 ` [PATCH v2 2/4] contrib/vhost-user-gpu: " Stefan Hajnoczi
2020-12-02 15:50 ` Marc-André Lureau
2020-12-03 9:51 ` Stefan Hajnoczi
2020-12-03 10:26 ` Marc-André Lureau
2020-12-03 11:37 ` Stefan Hajnoczi
2020-12-02 15:26 ` [PATCH v2 3/4] contrib/vhost-user-input: " Stefan Hajnoczi
2020-12-02 15:51 ` Marc-André Lureau
2020-12-03 9:52 ` Stefan Hajnoczi
2020-12-02 15:26 ` [PATCH v2 4/4] block/export: " Stefan Hajnoczi
2020-12-02 15:52 ` Marc-André Lureau
2020-12-02 15:58 ` Philippe Mathieu-Daudé
2020-12-03 13:41 ` [PATCH v2 0/4] vhost-user: avoid g_return_val_if() in get/set_config() Stefano Garzarella
2020-12-10 8:29 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202152611.677753-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).