From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E5B7C64E7C for ; Thu, 3 Dec 2020 01:04:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C0062173E for ; Thu, 3 Dec 2020 01:04:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C0062173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yadro.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkd3C-0005W9-2H for qemu-devel@archiver.kernel.org; Wed, 02 Dec 2020 20:04:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkd1j-0004Vg-OL; Wed, 02 Dec 2020 20:03:21 -0500 Received: from mta-02.yadro.com ([89.207.88.252]:35662 helo=mta-01.yadro.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkd1d-0001eU-WD; Wed, 02 Dec 2020 20:03:19 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id D9E0A41395; Thu, 3 Dec 2020 01:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received:received; s=mta-01; t=1606957388; x=1608771789; bh=WfzVPTjNGt9VA93TSpxzCdkIOg5R2xZCuP9WJ/ButXU=; b= gzjdKC5H/NsvRUbcAfoRTUgQao8MS0r+iX6TrppRg8peGy0wOKNadtjmwzNn1LS3 HU1rWBlbLWn9l0sMdgifeiu7ewD96Gm78Edn5Xvw2yDZsi6lSPztOMybPG+x/PeV iZOQ+TWDEsXWvccP8zBQbSDL7G9wGyyloVFAnTy7EAA= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZMnO_hM_SgLN; Thu, 3 Dec 2020 04:03:08 +0300 (MSK) Received: from T-EXCH-03.corp.yadro.com (t-exch-03.corp.yadro.com [172.17.100.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 05B2841377; Thu, 3 Dec 2020 04:03:08 +0300 (MSK) Received: from localhost (172.17.204.212) by T-EXCH-03.corp.yadro.com (172.17.100.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Thu, 3 Dec 2020 04:03:07 +0300 Date: Thu, 3 Dec 2020 04:03:26 +0300 From: Roman Bolshakov To: Alexander Graf Subject: Re: [PATCH v3 04/10] arm: Set PSCI to 0.2 for HVF Message-ID: <20201203010326.GB75161@SPB-NB-133.local> References: <20201202190408.2041-1-agraf@csgraf.de> <20201202190408.2041-5-agraf@csgraf.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201202190408.2041-5-agraf@csgraf.de> X-Originating-IP: [172.17.204.212] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-03.corp.yadro.com (172.17.100.103) Received-SPF: pass client-ip=89.207.88.252; envelope-from=r.bolshakov@yadro.com; helo=mta-01.yadro.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Richard Henderson , qemu-devel@nongnu.org, Cameron Esfahani , qemu-arm@nongnu.org, Frank Yang , Paolo Bonzini , Peter Collingbourne Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Dec 02, 2020 at 08:04:02PM +0100, Alexander Graf wrote: > In Hypervisor.framework, we just pass PSCI calls straight on to the QEMU emulation > of it. That means, if TCG is compatible with PSCI 0.2, so are we. Let's transpose > that fact in code too. > > Signed-off-by: Alexander Graf > --- > target/arm/cpu.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index 07492e9f9a..db6f7c34ed 100644 > --- a/target/arm/cpu.c > +++ b/target/arm/cpu.c > @@ -1062,6 +1062,10 @@ static void arm_cpu_initfn(Object *obj) > if (tcg_enabled()) { > cpu->psci_version = 2; /* TCG implements PSCI 0.2 */ > } > + > + if (hvf_enabled()) { > + cpu->psci_version = 2; /* HVF uses TCG's PSCI */ > + } If HVF is piggybacking on TCG and they're both the same versions would it be better if: > - if (tcg_enabled()) { > - cpu->psci_version = 2; /* TCG implements PSCI 0.2 */ > + if (tcg_enabled() || hvf_enabled()) { > + cpu->psci_version = 2; /* TCG implements PSCI 0.2 */ > } That'd avoid a case where they get out of sync. Thanks, Roman > } > > static Property arm_cpu_gt_cntfrq_property = > -- > 2.24.3 (Apple Git-128) >