From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH 2/9] console: add check for ui_info pointer
Date: Thu, 3 Dec 2020 12:07:58 +0100 [thread overview]
Message-ID: <20201203110806.13556-3-kraxel@redhat.com> (raw)
In-Reply-To: <20201203110806.13556-1-kraxel@redhat.com>
Verify the hw_ops->ui_info function pointer is non-zero before
calling it. Can be triggered by qxl which changes hw_ops when
switching between qxl-native and vga-compat modes.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/console.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ui/console.c b/ui/console.c
index 16b326854080..8930808d0b6d 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -1539,7 +1539,9 @@ static void dpy_set_ui_info_timer(void *opaque)
{
QemuConsole *con = opaque;
- con->hw_ops->ui_info(con->hw, con->head, &con->ui_info);
+ if (con->hw_ops->ui_info) {
+ con->hw_ops->ui_info(con->hw, con->head, &con->ui_info);
+ }
}
bool dpy_ui_info_supported(QemuConsole *con)
--
2.27.0
next prev parent reply other threads:[~2020-12-03 11:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 11:07 [PATCH 0/9] vnc: support some new extensions Gerd Hoffmann
2020-12-03 11:07 ` [PATCH 1/9] console: allow con==NULL in dpy_set_ui_info Gerd Hoffmann
2020-12-04 11:28 ` Marc-André Lureau
2020-12-03 11:07 ` Gerd Hoffmann [this message]
2020-12-04 11:32 ` [PATCH 2/9] console: add check for ui_info pointer Marc-André Lureau
2020-12-03 11:07 ` [PATCH 3/9] vnc: use enum for features Gerd Hoffmann
2020-12-04 11:32 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 4/9] vnc: drop unused copyrect feature Gerd Hoffmann
2020-12-04 11:32 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 5/9] vnc: add pseudo encodings Gerd Hoffmann
2020-12-04 11:34 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 6/9] vnc: add alpha cursor support Gerd Hoffmann
2020-12-04 11:39 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 7/9] vnc: force initial resize message Gerd Hoffmann
2020-12-04 11:57 ` Marc-André Lureau
2020-12-08 6:57 ` Gerd Hoffmann
2020-12-08 8:02 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 8/9] vnc: add support for extended desktop resize Gerd Hoffmann
2020-12-03 11:28 ` Daniel P. Berrangé
2020-12-04 6:37 ` Gerd Hoffmann
2020-12-04 12:25 ` Daniel P. Berrangé
2020-12-04 12:15 ` Daniel P. Berrangé
2020-12-04 12:24 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 9/9] qxl: add ui_info callback Gerd Hoffmann
2020-12-04 12:20 ` Daniel P. Berrangé
2020-12-04 12:45 ` Marc-André Lureau
2020-12-04 12:50 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203110806.13556-3-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).