From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH 7/9] vnc: force initial resize message
Date: Thu, 3 Dec 2020 12:08:03 +0100 [thread overview]
Message-ID: <20201203110806.13556-8-kraxel@redhat.com> (raw)
In-Reply-To: <20201203110806.13556-1-kraxel@redhat.com>
The vnc server should send desktop resize notifications unconditionally
on a new client connect, for feature negotiation reasons. Add a bool
flag to vnc_desktop_resize() to force sending the message even in case
there is no size change.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/vnc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 247e80d8f5c8..bdaf384f71a4 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -664,13 +664,14 @@ void vnc_framebuffer_update(VncState *vs, int x, int y, int w, int h,
}
-static void vnc_desktop_resize(VncState *vs)
+static void vnc_desktop_resize(VncState *vs, bool force)
{
if (vs->ioc == NULL || !vnc_has_feature(vs, VNC_FEATURE_RESIZE)) {
return;
}
if (vs->client_width == pixman_image_get_width(vs->vd->server) &&
- vs->client_height == pixman_image_get_height(vs->vd->server)) {
+ vs->client_height == pixman_image_get_height(vs->vd->server) &&
+ !force) {
return;
}
@@ -800,7 +801,7 @@ static void vnc_dpy_switch(DisplayChangeListener *dcl,
QTAILQ_FOREACH(vs, &vd->clients, next) {
vnc_colordepth(vs);
- vnc_desktop_resize(vs);
+ vnc_desktop_resize(vs, false);
if (vs->vd->cursor) {
vnc_cursor_define(vs);
}
@@ -2143,7 +2144,7 @@ static void set_encodings(VncState *vs, int32_t *encodings, size_t n_encodings)
break;
}
}
- vnc_desktop_resize(vs);
+ vnc_desktop_resize(vs, true);
check_pointer_type_change(&vs->mouse_mode_notifier, NULL);
vnc_led_state_change(vs);
if (vs->vd->cursor) {
--
2.27.0
next prev parent reply other threads:[~2020-12-03 11:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 11:07 [PATCH 0/9] vnc: support some new extensions Gerd Hoffmann
2020-12-03 11:07 ` [PATCH 1/9] console: allow con==NULL in dpy_set_ui_info Gerd Hoffmann
2020-12-04 11:28 ` Marc-André Lureau
2020-12-03 11:07 ` [PATCH 2/9] console: add check for ui_info pointer Gerd Hoffmann
2020-12-04 11:32 ` Marc-André Lureau
2020-12-03 11:07 ` [PATCH 3/9] vnc: use enum for features Gerd Hoffmann
2020-12-04 11:32 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 4/9] vnc: drop unused copyrect feature Gerd Hoffmann
2020-12-04 11:32 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 5/9] vnc: add pseudo encodings Gerd Hoffmann
2020-12-04 11:34 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 6/9] vnc: add alpha cursor support Gerd Hoffmann
2020-12-04 11:39 ` Marc-André Lureau
2020-12-03 11:08 ` Gerd Hoffmann [this message]
2020-12-04 11:57 ` [PATCH 7/9] vnc: force initial resize message Marc-André Lureau
2020-12-08 6:57 ` Gerd Hoffmann
2020-12-08 8:02 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 8/9] vnc: add support for extended desktop resize Gerd Hoffmann
2020-12-03 11:28 ` Daniel P. Berrangé
2020-12-04 6:37 ` Gerd Hoffmann
2020-12-04 12:25 ` Daniel P. Berrangé
2020-12-04 12:15 ` Daniel P. Berrangé
2020-12-04 12:24 ` Marc-André Lureau
2020-12-03 11:08 ` [PATCH 9/9] qxl: add ui_info callback Gerd Hoffmann
2020-12-04 12:20 ` Daniel P. Berrangé
2020-12-04 12:45 ` Marc-André Lureau
2020-12-04 12:50 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203110806.13556-8-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).