* [PATCH] pcie_aer: Fix help message of pcie_aer_inject_error command
@ 2020-12-04 3:09 Zenghui Yu
2020-12-04 9:55 ` Dr. David Alan Gilbert
2020-12-08 18:37 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 4+ messages in thread
From: Zenghui Yu @ 2020-12-04 3:09 UTC (permalink / raw)
To: mst, marcel.apfelbaum, dgilbert; +Cc: Zenghui Yu, wanghaibin.wang, qemu-devel
There is an interesting typo in the help message of pcie_aer_inject_error
command. Use 'tlp' instead of 'tlb' to match the PCIe AER term.
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
hmp-commands.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index ff2d7aa8f3..dd460eb908 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1302,8 +1302,8 @@ ERST
" -c for correctable error\n\t\t\t"
"<id> = qdev device id\n\t\t\t"
"<error_status> = error string or 32bit\n\t\t\t"
- "<tlb header> = 32bit x 4\n\t\t\t"
- "<tlb header prefix> = 32bit x 4",
+ "<tlp header> = 32bit x 4\n\t\t\t"
+ "<tlp header prefix> = 32bit x 4",
.cmd = hmp_pcie_aer_inject_error,
},
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pcie_aer: Fix help message of pcie_aer_inject_error command
2020-12-04 3:09 [PATCH] pcie_aer: Fix help message of pcie_aer_inject_error command Zenghui Yu
@ 2020-12-04 9:55 ` Dr. David Alan Gilbert
2020-12-08 18:37 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2020-12-04 9:55 UTC (permalink / raw)
To: Zenghui Yu; +Cc: wanghaibin.wang, qemu-devel, mst
* Zenghui Yu (yuzenghui@huawei.com) wrote:
> There is an interesting typo in the help message of pcie_aer_inject_error
> command. Use 'tlp' instead of 'tlb' to match the PCIe AER term.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Well spotted; thanks!
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hmp-commands.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index ff2d7aa8f3..dd460eb908 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1302,8 +1302,8 @@ ERST
> " -c for correctable error\n\t\t\t"
> "<id> = qdev device id\n\t\t\t"
> "<error_status> = error string or 32bit\n\t\t\t"
> - "<tlb header> = 32bit x 4\n\t\t\t"
> - "<tlb header prefix> = 32bit x 4",
> + "<tlp header> = 32bit x 4\n\t\t\t"
> + "<tlp header prefix> = 32bit x 4",
> .cmd = hmp_pcie_aer_inject_error,
> },
>
> --
> 2.19.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pcie_aer: Fix help message of pcie_aer_inject_error command
2020-12-04 3:09 [PATCH] pcie_aer: Fix help message of pcie_aer_inject_error command Zenghui Yu
2020-12-04 9:55 ` Dr. David Alan Gilbert
@ 2020-12-08 18:37 ` Dr. David Alan Gilbert
2020-12-08 18:40 ` Michael S. Tsirkin
1 sibling, 1 reply; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2020-12-08 18:37 UTC (permalink / raw)
To: Zenghui Yu; +Cc: wanghaibin.wang, qemu-devel, mst
* Zenghui Yu (yuzenghui@huawei.com) wrote:
> There is an interesting typo in the help message of pcie_aer_inject_error
> command. Use 'tlp' instead of 'tlb' to match the PCIe AER term.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Queued
> ---
> hmp-commands.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index ff2d7aa8f3..dd460eb908 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1302,8 +1302,8 @@ ERST
> " -c for correctable error\n\t\t\t"
> "<id> = qdev device id\n\t\t\t"
> "<error_status> = error string or 32bit\n\t\t\t"
> - "<tlb header> = 32bit x 4\n\t\t\t"
> - "<tlb header prefix> = 32bit x 4",
> + "<tlp header> = 32bit x 4\n\t\t\t"
> + "<tlp header prefix> = 32bit x 4",
> .cmd = hmp_pcie_aer_inject_error,
> },
>
> --
> 2.19.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pcie_aer: Fix help message of pcie_aer_inject_error command
2020-12-08 18:37 ` Dr. David Alan Gilbert
@ 2020-12-08 18:40 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2020-12-08 18:40 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: Zenghui Yu, wanghaibin.wang, qemu-devel
On Tue, Dec 08, 2020 at 06:37:53PM +0000, Dr. David Alan Gilbert wrote:
> * Zenghui Yu (yuzenghui@huawei.com) wrote:
> > There is an interesting typo in the help message of pcie_aer_inject_error
> > command. Use 'tlp' instead of 'tlb' to match the PCIe AER term.
> >
> > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
>
> Queued
Oh I just queued it too ;) should not be a problem ...
> > ---
> > hmp-commands.hx | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index ff2d7aa8f3..dd460eb908 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -1302,8 +1302,8 @@ ERST
> > " -c for correctable error\n\t\t\t"
> > "<id> = qdev device id\n\t\t\t"
> > "<error_status> = error string or 32bit\n\t\t\t"
> > - "<tlb header> = 32bit x 4\n\t\t\t"
> > - "<tlb header prefix> = 32bit x 4",
> > + "<tlp header> = 32bit x 4\n\t\t\t"
> > + "<tlp header prefix> = 32bit x 4",
> > .cmd = hmp_pcie_aer_inject_error,
> > },
> >
> > --
> > 2.19.1
> >
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-08 18:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-04 3:09 [PATCH] pcie_aer: Fix help message of pcie_aer_inject_error command Zenghui Yu
2020-12-04 9:55 ` Dr. David Alan Gilbert
2020-12-08 18:37 ` Dr. David Alan Gilbert
2020-12-08 18:40 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).