From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: wanghaibin.wang@huawei.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [PATCH] pcie_aer: Fix help message of pcie_aer_inject_error command
Date: Fri, 4 Dec 2020 09:55:06 +0000 [thread overview]
Message-ID: <20201204095506.GA2883@work-vm> (raw)
In-Reply-To: <20201204030953.837-1-yuzenghui@huawei.com>
* Zenghui Yu (yuzenghui@huawei.com) wrote:
> There is an interesting typo in the help message of pcie_aer_inject_error
> command. Use 'tlp' instead of 'tlb' to match the PCIe AER term.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Well spotted; thanks!
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hmp-commands.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index ff2d7aa8f3..dd460eb908 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1302,8 +1302,8 @@ ERST
> " -c for correctable error\n\t\t\t"
> "<id> = qdev device id\n\t\t\t"
> "<error_status> = error string or 32bit\n\t\t\t"
> - "<tlb header> = 32bit x 4\n\t\t\t"
> - "<tlb header prefix> = 32bit x 4",
> + "<tlp header> = 32bit x 4\n\t\t\t"
> + "<tlp header prefix> = 32bit x 4",
> .cmd = hmp_pcie_aer_inject_error,
> },
>
> --
> 2.19.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-12-04 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 3:09 [PATCH] pcie_aer: Fix help message of pcie_aer_inject_error command Zenghui Yu
2020-12-04 9:55 ` Dr. David Alan Gilbert [this message]
2020-12-08 18:37 ` Dr. David Alan Gilbert
2020-12-08 18:40 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204095506.GA2883@work-vm \
--to=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).