From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03876C433FE for ; Fri, 4 Dec 2020 10:41:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D8942251E for ; Fri, 4 Dec 2020 10:41:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D8942251E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kl8WP-0006UY-Ng for qemu-devel@archiver.kernel.org; Fri, 04 Dec 2020 05:41:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kl8Vo-0005s8-GO for qemu-devel@nongnu.org; Fri, 04 Dec 2020 05:40:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kl8Vl-00015Y-RM for qemu-devel@nongnu.org; Fri, 04 Dec 2020 05:40:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607078424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jo2jqT1d/6fq0h6/2JrhApA16BGi4FCBjjlClP4m6jw=; b=abp4+wjmg8sW5hIYP6pLLiDSWSmEYd135VqXXXmbemOpn/XEJweqLjUFcjxBTDgc7lE9/I JBmsizBJgimIN+bAQY7nVLl6bVTEv2RK1WV/8dE+5esQxPjMcqUwVi4yYV1z9iYAlSiniy fE9qa9wrNbKA/Leargxc8pCANzSXbYg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-ySk9CGeRMAeGShFsMaCpGg-1; Fri, 04 Dec 2020 05:40:20 -0500 X-MC-Unique: ySk9CGeRMAeGShFsMaCpGg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 99D438015F3; Fri, 4 Dec 2020 10:40:19 +0000 (UTC) Received: from merkur.fritz.box (ovpn-114-112.ams2.redhat.com [10.36.114.112]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EAA56085A; Fri, 4 Dec 2020 10:40:17 +0000 (UTC) Date: Fri, 4 Dec 2020 11:40:16 +0100 From: Kevin Wolf To: Li Feng Subject: Re: [PATCH] file-posix: check the use_lock Message-ID: <20201204104016.GC4833@merkur.fritz.box> References: <1607077703-32344-1-git-send-email-fengli@smartx.com> MIME-Version: 1.0 In-Reply-To: <1607077703-32344-1-git-send-email-fengli@smartx.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lifeng1519@gmail.com, kyle@smartx.com, "open list:All patches CC here" , "open list:raw" , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 04.12.2020 um 11:28 hat Li Feng geschrieben: > When setting the file.locking = false, we shouldn't set the lock. > > Signed-off-by: Li Feng This looks right to me, but can you add a test for this scenario to iotest 182? This would both demonstrate the effect of the bug (I think it would be that files are locked after reopen even with locking=off?) and make sure that we won't have a regression later. Mentioning the effect in the commit message would be good, too. Kevin > block/file-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/file-posix.c b/block/file-posix.c > index d5fd1dbcd2..806764f7e3 100644 > --- a/block/file-posix.c > +++ b/block/file-posix.c > @@ -3104,7 +3104,7 @@ static int raw_check_perm(BlockDriverState *bs, uint64_t perm, uint64_t shared, > } > > /* Copy locks to the new fd */ > - if (s->perm_change_fd) { > + if (s->perm_change_fd && s->use_lock) { > ret = raw_apply_lock_bytes(NULL, s->perm_change_fd, perm, ~shared, > false, errp); > if (ret < 0) { > -- > 2.24.3 >