[PATCH 0/1] Remove flatview_simplify()

[PATCH 0/1] Remove flatview_simplify()

[FelixCuioc]

When assign EHCI device to the virtual machine,
after initializing EHCI in seabios,it will continuously
send dma cycles.
Flatview_simplify() will merge a very large range.The IOVA
mappings of the EHCI device will be innocently unmapped
between the delete and add phases of the VFIO MemoryListener.
At this time,the IOMMU will block the DMA cycle.
We want to remove flatview_simplify() is to prevent EHCI
device IOVA mappings from being unmapped.

FelixCui-oc (1):
  Remove flatview_simplify()

 softmmu/memory.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.17.1

[PATCH 1/1] Remove flatview_simplify()

[FelixCuioc]

From: FelixCui-oc <FelixCui-oc@zhaoxin.com>

Flatview_simplify() will cause some innocent mappings
to be unmapped.

Signed-off-by: FelixCui-oc <FelixCui-oc@zhaoxin.com>
Signed-off-by: FelixCuioc <FelixCui-oc@zhaoxin.com>
---
 softmmu/memory.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/softmmu/memory.c b/softmmu/memory.c
index 11ca94d037..66d36dcac4 100644
--- a/softmmu/memory.c
+++ b/softmmu/memory.c
@@ -733,7 +733,6 @@ static FlatView *generate_memory_topology(MemoryRegion *mr)
                              addrrange_make(int128_zero(), int128_2_64()),
                              false, false);
     }
-    flatview_simplify(view);
 
     view->dispatch = address_space_dispatch_new(view);
     for (i = 0; i < view->nr; i++) {
-- 
2.17.1

Re: [PATCH 1/1] Remove flatview_simplify()

[Paolo Bonzini]

On 06/12/20 09:21, FelixCuioc wrote:
> From: FelixCui-oc <FelixCui-oc@zhaoxin.com>
> 
> Flatview_simplify() will cause some innocent mappings
> to be unmapped.
> 
> Signed-off-by: FelixCui-oc <FelixCui-oc@zhaoxin.com>
> Signed-off-by: FelixCuioc <FelixCui-oc@zhaoxin.com>
> ---
>   softmmu/memory.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/softmmu/memory.c b/softmmu/memory.c
> index 11ca94d037..66d36dcac4 100644
> --- a/softmmu/memory.c
> +++ b/softmmu/memory.c
> @@ -733,7 +733,6 @@ static FlatView *generate_memory_topology(MemoryRegion *mr)
>                                addrrange_make(int128_zero(), int128_2_64()),
>                                false, false);
>       }
> -    flatview_simplify(view);
>   
>       view->dispatch = address_space_dispatch_new(view);
>       for (i = 0; i < view->nr; i++) {
> 

This will give a warning about an unused static function.  You have to 
clean that up too.

Also please include more information from the previous discussions in 
the commut message, thanks.

Paolo

[PATCH 0/1] Remove flatview_simplify()

[FelixCuioc]

When assign EHCI device to the virtual machine,
after initializing EHCI in seabios,it will continuously
send dma cycles.
Flatview_simplify() will merge a very large range.The IOVA
mappings of the EHCI device will be innocently unmapped
between the delete and add phases of the VFIO MemoryListener.
At this time,the IOMMU will block the DMA cycle.
We want to remove flatview_simplify() is to prevent EHCI
device IOVA mappings from being unmapped.

FelixCuioc (1):
  Remove flatview_simplify()

 softmmu/memory.c | 37 -------------------------------------
 1 file changed, 37 deletions(-)

-- 
2.17.1