qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: jasowang@redhat.com, fnu.vikram@xilinx.com,
	qemu-devel@nongnu.org, pisa@cmp.felk.cvut.cz
Subject: Re: [PATCH 0/4] User creatable object property setting fixes
Date: Mon, 7 Dec 2020 10:30:27 +0000	[thread overview]
Message-ID: <20201207103027.GH3102898@redhat.com> (raw)
In-Reply-To: <20201130105615.21799-1-kwolf@redhat.com>

On Mon, Nov 30, 2020 at 11:56:11AM +0100, Kevin Wolf wrote:
> While writing a QAPI schema for all user creatable QOM objects, I found
> a few problems in the existing property setting code of objects.
> 
> This series fixes some crashes and memory leaks related to property
> setting in user creatable objects.
> 
> There are many more problems of the sort that updating a property at
> runtime is allowed by most objects, but they aren't actually prepared to
> handle the update, so it doesn't result in the expected behaviour. I'm
> not trying to fix bugs of this class in this series.
> 
> Kevin Wolf (4):
>   crypto: Move USER_CREATABLE to secret_common base class
>   crypto: Forbid broken unloading of secrets
>   crypto: Fix memory leaks in set_loaded for tls-*

I've queued these three patches

>   can-host: Fix crash when 'canbus' property is not set
> 
>  crypto/secret.c         | 14 --------------
>  crypto/secret_common.c  | 21 ++++++++++++++++++---
>  crypto/secret_keyring.c | 14 --------------
>  crypto/tlscredsanon.c   |  3 +--
>  crypto/tlscredspsk.c    |  3 +--
>  crypto/tlscredsx509.c   |  3 +--
>  net/can/can_host.c      |  5 +++++
>  7 files changed, 26 insertions(+), 37 deletions(-)

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



      parent reply	other threads:[~2020-12-07 10:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 10:56 [PATCH 0/4] User creatable object property setting fixes Kevin Wolf
2020-11-30 10:56 ` [PATCH 1/4] crypto: Move USER_CREATABLE to secret_common base class Kevin Wolf
2020-11-30 10:56 ` [PATCH 2/4] crypto: Forbid broken unloading of secrets Kevin Wolf
2020-11-30 10:56 ` [PATCH 3/4] crypto: Fix memory leaks in set_loaded for tls-* Kevin Wolf
2020-11-30 10:56 ` [PATCH 4/4] can-host: Fix crash when 'canbus' property is not set Kevin Wolf
2020-12-07 10:30 ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201207103027.GH3102898@redhat.com \
    --to=berrange@redhat.com \
    --cc=fnu.vikram@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pisa@cmp.felk.cvut.cz \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).