qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Maxim Levitsky <mlevitsk@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Maxim Levitsky <mlevitsk@redhat.com>,
	Alberto Garcia <berto@igalia.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH v3 1/2] crypto: luks: Fix tiny memory leak
Date: Tue,  8 Dec 2020 16:21:58 +0200	[thread overview]
Message-ID: <20201208142159.492489-2-mlevitsk@redhat.com> (raw)
In-Reply-To: <20201208142159.492489-1-mlevitsk@redhat.com>

When the underlying block device doesn't support the
bdrv_co_delete_file interface, an 'Error' object was leaked.

Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
---
 block/crypto.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/block/crypto.c b/block/crypto.c
index aef5a5721a..b3a5275132 100644
--- a/block/crypto.c
+++ b/block/crypto.c
@@ -735,6 +735,8 @@ fail:
          */
         if ((r_del < 0) && (r_del != -ENOTSUP)) {
             error_report_err(local_delete_err);
+        } else {
+            error_free(local_delete_err);
         }
     }
 
-- 
2.26.2



  reply	other threads:[~2020-12-08 14:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 14:21 [PATCH v3 0/2] qcow2: don't leave partially initialized file on image creation Maxim Levitsky
2020-12-08 14:21 ` Maxim Levitsky [this message]
2020-12-08 15:25   ` [PATCH v3 1/2] crypto: luks: Fix tiny memory leak Alberto Garcia
2020-12-08 14:21 ` [PATCH v3 2/2] block: qcow2: remove the created file on initialization error Maxim Levitsky
2020-12-08 15:26   ` Alberto Garcia
2020-12-08 15:29     ` Maxim Levitsky
2020-12-08 15:47   ` Vladimir Sementsov-Ogievskiy
2020-12-08 16:27     ` Maxim Levitsky
2020-12-08 16:54       ` Vladimir Sementsov-Ogievskiy
2020-12-08 17:11         ` Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201208142159.492489-2-mlevitsk@redhat.com \
    --to=mlevitsk@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).