From: Maxim Levitsky <mlevitsk@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
Alberto Garcia <berto@igalia.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH v4 0/4] qcow2: don't leave partially initialized file on image creation
Date: Wed, 9 Dec 2020 18:44:37 +0200 [thread overview]
Message-ID: <20201209164441.867945-1-mlevitsk@redhat.com> (raw)
Use the bdrv_co_delete_file interface to delete the underlying
file if qcow2 initialization fails (e.g due to bad encryption secret)
This makes the qcow2 driver behave the same way as the luks driver behaves.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1845353
V3: addressed review feedback and reworked commit messages
V4: got rid of code duplication by adding bdrv_co_delete_file_noerr
and made the qcow2 driver use this function to delete
both the main and the data file.
Best regards,
Maxim Levitsky
Maxim Levitsky (4):
crypto: luks: Fix tiny memory leak
block: add bdrv_co_delete_file_noerr
crypto: luks: use bdrv_co_delete_file_noerr
block: qcow2: remove the created file on initialization error
block.c | 23 +++++++++++++++++++++++
block/crypto.c | 13 ++-----------
block/qcow2.c | 7 ++++---
include/block/block.h | 1 +
4 files changed, 30 insertions(+), 14 deletions(-)
--
2.26.2
next reply other threads:[~2020-12-09 16:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 16:44 Maxim Levitsky [this message]
2020-12-09 16:44 ` [PATCH v4 1/4] crypto: luks: Fix tiny memory leak Maxim Levitsky
2020-12-09 16:44 ` [PATCH v4 2/4] block: add bdrv_co_delete_file_noerr Maxim Levitsky
2020-12-09 17:34 ` Alberto Garcia
2020-12-09 20:26 ` Maxim Levitsky
2020-12-09 16:44 ` [PATCH v4 3/4] crypto: luks: use bdrv_co_delete_file_noerr Maxim Levitsky
2020-12-09 17:34 ` Alberto Garcia
2020-12-09 16:44 ` [PATCH v4 4/4] block: qcow2: remove the created file on initialization error Maxim Levitsky
2020-12-09 17:41 ` Alberto Garcia
2020-12-09 20:33 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209164441.867945-1-mlevitsk@redhat.com \
--to=mlevitsk@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).