From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jiahui Cen <cenjiahui@huawei.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Yubo Miao <miaoyubo@huawei.com>,
qemu-arm@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Subject: [PULL v2 12/65] acpi/gpex: Build tables for pxb
Date: Wed, 9 Dec 2020 13:07:42 -0500 [thread overview]
Message-ID: <20201209180546.721296-13-mst@redhat.com> (raw)
In-Reply-To: <20201209180546.721296-1-mst@redhat.com>
From: Yubo Miao <miaoyubo@huawei.com>
The resources of pxbs are obtained by crs_build and the resources
used by pxbs would be moved from the resources defined for host-bridge.
The resources for pxb are composed of following two parts:
1. The bar space of the pci-bridge/pcie-root-port behined it
2. The config space of devices behind it.
Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
Message-Id: <20201119014841.7298-6-cenjiahui@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/pci-host/gpex.h | 1 +
hw/arm/virt-acpi-build.c | 6 +++--
hw/pci-host/gpex-acpi.c | 54 ++++++++++++++++++++++++++++++++++++++
3 files changed, 59 insertions(+), 2 deletions(-)
diff --git a/include/hw/pci-host/gpex.h b/include/hw/pci-host/gpex.h
index d52ea80d4e..d48a020a95 100644
--- a/include/hw/pci-host/gpex.h
+++ b/include/hw/pci-host/gpex.h
@@ -59,6 +59,7 @@ struct GPEXConfig {
MemMapEntry mmio64;
MemMapEntry pio;
int irq;
+ PCIBus *bus;
};
int gpex_set_irq_num(GPEXHost *s, int index, int gsi);
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 9747a6458f..e0bed9037c 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -153,7 +153,8 @@ static void acpi_dsdt_add_virtio(Aml *scope,
}
static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
- uint32_t irq, bool use_highmem, bool highmem_ecam)
+ uint32_t irq, bool use_highmem, bool highmem_ecam,
+ VirtMachineState *vms)
{
int ecam_id = VIRT_ECAM_ID(highmem_ecam);
struct GPEXConfig cfg = {
@@ -161,6 +162,7 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
.pio = memmap[VIRT_PCIE_PIO],
.ecam = memmap[ecam_id],
.irq = irq,
+ .bus = vms->bus,
};
if (use_highmem) {
@@ -609,7 +611,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
acpi_dsdt_add_virtio(scope, &memmap[VIRT_MMIO],
(irqmap[VIRT_MMIO] + ARM_SPI_BASE), NUM_VIRTIO_TRANSPORTS);
acpi_dsdt_add_pci(scope, memmap, (irqmap[VIRT_PCIE] + ARM_SPI_BASE),
- vms->highmem, vms->highmem_ecam);
+ vms->highmem, vms->highmem_ecam, vms);
if (vms->acpi_dev) {
build_ged_aml(scope, "\\_SB."GED_DEVICE,
HOTPLUG_HANDLER(vms->acpi_dev),
diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c
index 32a9f2796d..7f20ee1c98 100644
--- a/hw/pci-host/gpex-acpi.c
+++ b/hw/pci-host/gpex-acpi.c
@@ -1,6 +1,10 @@
#include "qemu/osdep.h"
#include "hw/acpi/aml-build.h"
#include "hw/pci-host/gpex.h"
+#include "hw/arm/virt.h"
+#include "hw/pci/pci_bus.h"
+#include "hw/pci/pci_bridge.h"
+#include "hw/pci/pcie_host.h"
static void acpi_dsdt_add_pci_route_table(Aml *dev, uint32_t irq)
{
@@ -124,7 +128,57 @@ void acpi_dsdt_add_gpex(Aml *scope, struct GPEXConfig *cfg)
{
int nr_pcie_buses = cfg->ecam.size / PCIE_MMCFG_SIZE_MIN;
Aml *method, *crs, *dev, *rbuf;
+ PCIBus *bus = cfg->bus;
+ CrsRangeSet crs_range_set;
+ /* start to construct the tables for pxb */
+ crs_range_set_init(&crs_range_set);
+ if (bus) {
+ QLIST_FOREACH(bus, &bus->child, sibling) {
+ uint8_t bus_num = pci_bus_num(bus);
+ uint8_t numa_node = pci_bus_numa_node(bus);
+
+ if (!pci_bus_is_root(bus)) {
+ continue;
+ }
+
+ /*
+ * 0 - (nr_pcie_buses - 1) is the bus range for the main
+ * host-bridge and it equals the MIN of the
+ * busNr defined for pxb-pcie.
+ */
+ if (bus_num < nr_pcie_buses) {
+ nr_pcie_buses = bus_num;
+ }
+
+ dev = aml_device("PC%.02X", bus_num);
+ aml_append(dev, aml_name_decl("_HID", aml_string("PNP0A08")));
+ aml_append(dev, aml_name_decl("_CID", aml_string("PNP0A03")));
+ aml_append(dev, aml_name_decl("_BBN", aml_int(bus_num)));
+ aml_append(dev, aml_name_decl("_UID", aml_int(bus_num)));
+ aml_append(dev, aml_name_decl("_STR", aml_unicode("pxb Device")));
+ if (numa_node != NUMA_NODE_UNASSIGNED) {
+ aml_append(dev, aml_name_decl("_PXM", aml_int(numa_node)));
+ }
+
+ acpi_dsdt_add_pci_route_table(dev, cfg->irq);
+
+ /*
+ * Resources defined for PXBs are composed by the folling parts:
+ * 1. The resources the pci-brige/pcie-root-port need.
+ * 2. The resources the devices behind pxb need.
+ */
+ crs = build_crs(PCI_HOST_BRIDGE(BUS(bus)->parent), &crs_range_set);
+ aml_append(dev, aml_name_decl("_CRS", crs));
+
+ acpi_dsdt_add_pci_osc(dev);
+
+ aml_append(scope, dev);
+ }
+ }
+ crs_range_set_free(&crs_range_set);
+
+ /* tables for the main */
dev = aml_device("%s", "PCI0");
aml_append(dev, aml_name_decl("_HID", aml_string("PNP0A08")));
aml_append(dev, aml_name_decl("_CID", aml_string("PNP0A03")));
--
MST
next prev parent reply other threads:[~2020-12-09 18:38 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 18:06 [PULL v2 00/65] pc,pci,virtio: fixes, cleanups Michael S. Tsirkin
2020-12-09 18:06 ` [PULL v2 01/65] vhost-user-scsi: Fix memleaks in vus_proc_req() Michael S. Tsirkin
2020-12-09 18:06 ` [PULL v2 02/65] memory: Rename memory_region_notify_one to memory_region_notify_iommu_one Michael S. Tsirkin
2020-12-09 18:06 ` [PULL v2 03/65] memory: Add IOMMUTLBEvent Michael S. Tsirkin
2020-12-09 18:06 ` [PULL v2 04/65] memory: Add IOMMU_NOTIFIER_DEVIOTLB_UNMAP IOMMUTLBNotificationType Michael S. Tsirkin
2020-12-09 18:06 ` [PULL v2 05/65] intel_iommu: Skip page walking on device iotlb invalidations Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 06/65] memory: Skip bad range assertion if notifier is DEVIOTLB_UNMAP type Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 07/65] virtio: reset device on bad guest index in virtio_load() Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 08/65] acpi/gpex: Extract two APIs from acpi_dsdt_add_pci Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 09/65] fw_cfg: Refactor extra pci roots addition Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 10/65] hw/arm/virt: Write extra pci roots into fw_cfg Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 11/65] acpi: Extract crs build form acpi_build.c Michael S. Tsirkin
2020-12-09 18:07 ` Michael S. Tsirkin [this message]
2020-12-09 18:07 ` [PULL v2 13/65] acpi: Align the size to 128k Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 14/65] unit-test: The files changed Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 15/65] unit-test: Add testcase for pxb Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 16/65] unit-test: Add the binary file and clear diff.h Michael S. Tsirkin
2020-12-09 18:07 ` [PULL v2 17/65] failover: fix indentantion Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 18/65] failover: Use always atomics for primary_should_be_hidden Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 19/65] failover: primary bus is only used once, and where it is set Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 20/65] failover: Remove unused parameter Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 21/65] failover: Remove external partially_hotplugged property Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 22/65] failover: qdev_device_add() returns err or dev set Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 23/65] failover: Rename bool to failover_primary_hidden Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 24/65] failover: g_strcmp0() knows how to handle NULL Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 25/65] failover: Remove primary_device_opts Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 26/65] failover: remove standby_id variable Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 27/65] failover: Remove primary_device_dict Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 28/65] failover: Remove memory leak Michael S. Tsirkin
2020-12-09 18:08 ` [PULL v2 29/65] failover: simplify virtio_net_find_primary() Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 30/65] failover: should_be_hidden() should take a bool Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 31/65] failover: Rename function to hide_device() Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 32/65] failover: virtio_net_connect_failover_devices() does nothing Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 33/65] failover: Rename to failover_find_primary_device() Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 34/65] failover: simplify qdev_device_add() failover case Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 35/65] failover: simplify qdev_device_add() Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 36/65] failover: make sure that id always exist Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 37/65] failover: remove failover_find_primary_device() error parameter Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 38/65] failover: split failover_find_primary_device_id() Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 39/65] failover: We don't need to cache primary_device_id anymore Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 40/65] failover: Caller of this two functions already have primary_dev Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 41/65] failover: simplify failover_unplug_primary Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 42/65] failover: Remove primary_dev member Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 43/65] hw: add compat machines for 6.0 Michael S. Tsirkin
2020-12-09 18:09 ` [PULL v2 44/65] libvhost-user: replace qemu/bswap.h with glibc endian.h Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 45/65] libvhost-user: replace qemu/memfd.h usage Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 46/65] libvhost-user: remove qemu/compiler.h usage Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 47/65] libvhost-user: drop qemu/osdep.h dependency Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 48/65] libvhost-user: make it a meson subproject Michael S. Tsirkin
2020-12-10 16:09 ` Peter Maydell
2020-12-10 16:17 ` Paolo Bonzini
2020-12-10 16:26 ` Peter Maydell
2020-12-09 18:10 ` [PULL v2 49/65] libvhost-user: add a simple link test without glib Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 50/65] .gitlab-ci: add build-libvhost-user Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 51/65] contrib/vhost-user-blk: avoid g_return_val_if() input validation Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 52/65] contrib/vhost-user-gpu: " Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 53/65] contrib/vhost-user-input: " Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 54/65] block/export: " Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 55/65] hw/i386/pc: add max combined fw size as machine configuration option Michael S. Tsirkin
2020-12-09 18:10 ` [PULL v2 56/65] acpi: cpuhp: introduce 'firmware performs eject' status/control bits Michael S. Tsirkin
2020-12-09 18:11 ` [PULL v2 57/65] x86: acpi: introduce AcpiPmInfo::smi_on_cpu_unplug Michael S. Tsirkin
2020-12-09 18:11 ` [PULL v2 58/65] tests/acpi: allow expected files change Michael S. Tsirkin
2020-12-09 18:11 ` [PULL v2 59/65] x86: acpi: let the firmware handle pending "CPU remove" events in SMM Michael S. Tsirkin
2020-12-09 18:11 ` [PULL v2 60/65] tests/acpi: update expected files Michael S. Tsirkin
2020-12-09 18:11 ` [PULL v2 61/65] x86: ich9: factor out "guest_cpu_hotplug_features" Michael S. Tsirkin
2020-12-09 18:11 ` [PULL v2 62/65] x86: ich9: let firmware negotiate 'CPU hot-unplug with SMI' feature Michael S. Tsirkin
2020-12-09 18:11 ` [PULL v2 63/65] pcie_aer: Fix help message of pcie_aer_inject_error command Michael S. Tsirkin
2020-12-09 18:11 ` [PULL v2 64/65] hw/virtio-pci Added counter for pcie capabilities offsets Michael S. Tsirkin
2020-12-09 18:11 ` [PULL v2 65/65] hw/virtio-pci Added AER capability Michael S. Tsirkin
2020-12-09 21:42 ` [PULL v2 00/65] pc,pci,virtio: fixes, cleanups Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209180546.721296-13-mst@redhat.com \
--to=mst@redhat.com \
--cc=cenjiahui@huawei.com \
--cc=imammedo@redhat.com \
--cc=miaoyubo@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).