From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C529EC433FE for ; Thu, 10 Dec 2020 02:11:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15EAC2343F for ; Thu, 10 Dec 2020 02:10:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15EAC2343F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knBQ2-0007H0-Oy for qemu-devel@archiver.kernel.org; Wed, 09 Dec 2020 21:10:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knBO7-0006nD-4l for qemu-devel@nongnu.org; Wed, 09 Dec 2020 21:08:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1knBNy-0001rL-QV for qemu-devel@nongnu.org; Wed, 09 Dec 2020 21:08:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607566127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jf1/1X4YnO7VtDijfV9FEnR1Y3UtMrA4GiDIxWU3vDM=; b=JOwyBQJgqmfpgCIZgTr4y6M6YcnEx8E6aLUpLA1ZHHqi1LxNJXeXec0s9j+uVdBUbMNda4 1tE8pLByJU5DJWpY5JoPHzAwHF/a0P8jBf+FhvGOXN5uvbX6fwmjPhlFxBqtA1nLDT2raO ltg3pGbPwUomQzjubZ7QJG01ZTzpceU= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-L0fQ5rkmM6uR4W7TApCJgg-1; Wed, 09 Dec 2020 21:08:46 -0500 X-MC-Unique: L0fQ5rkmM6uR4W7TApCJgg-1 Received: by mail-qk1-f198.google.com with SMTP id z129so2653796qkb.13 for ; Wed, 09 Dec 2020 18:08:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Jf1/1X4YnO7VtDijfV9FEnR1Y3UtMrA4GiDIxWU3vDM=; b=hyvXVr7gxo6N8l+SLFNK2m/+/HnKcAlxszf+eEBu/vvTiVCz1f7iEWgIUpooh9iI3v HeGRBLwBdkYVP6pwgjcg+H5ipr97mi/URPb7WRoWJ+xtvMRZ6wnX7xTDncCTZdROBrtF 6HH1u2oCRFunpgYx0gBnExWtZ/JZv0WAkD81CDanqXEsOAQdqJeWohzgxVtgiUn1vNtw 5Qgv7wUTPbBIJc9JRQoXEG4rw8FPNnGIm/EwW9psVMnrXFz6fV1/Vth+hqRXOMYHMl+H V3iK/GGRzu2B/VTzEDFVPTTXnVJyBvTFdZ01yIyIkZixEa3CsMnmys78uSHnX74Mvz8r nSlQ== X-Gm-Message-State: AOAM531ohW9VFXpVBAxG/MSb97r9xZYqKIgq+EJCLbGwy1td44QtAPhb +gaxQWnzulscTUWDCgEUa8GDIglwBU53zmk83l368vyNcMwUDBXUXJml+yJEJaB62JHAIbYzftf hDqdnFPjI+fdRIbs= X-Received: by 2002:ae9:ebd5:: with SMTP id b204mr6314217qkg.195.1607566125719; Wed, 09 Dec 2020 18:08:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJxI8aOTk8eEfkmR7fk8ueNpeKozgNDK6u79EM2P252ac8OAnWQ/P91PLbLFC5JhAhlUyjU0Mw== X-Received: by 2002:ae9:ebd5:: with SMTP id b204mr6314193qkg.195.1607566125494; Wed, 09 Dec 2020 18:08:45 -0800 (PST) Received: from xz-x1 ([142.126.83.202]) by smtp.gmail.com with ESMTPSA id s11sm2677291qkm.124.2020.12.09.18.08.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Dec 2020 18:08:44 -0800 (PST) Date: Wed, 9 Dec 2020 21:08:43 -0500 From: Peter Xu To: zhukeqian Subject: Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap Message-ID: <20201210020843.GB3211@xz-x1> References: <20201208114013.875-1-yuzenghui@huawei.com> <20201208151654.GA6432@xz-x1> <6dc82702-9246-4684-4f28-e104abc0c11d@huawei.com> MIME-Version: 1.0 In-Reply-To: <6dc82702-9246-4684-4f28-e104abc0c11d@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zenghui Yu , pbonzini@redhat.com, qemu-devel@nongnu.org, wanghaibin.wang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Keqian, On Thu, Dec 10, 2020 at 09:46:06AM +0800, zhukeqian wrote: > Hi, > > I see that if start or size is not PAGE aligned, it also clears areas > which beyond caller's expectation, so do we also need to consider this? Could you elaborate? If start_delta != 0, kvm_log_clear_one_slot() should already go the slow path. Thanks, -- Peter Xu