From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com,
"Alex Bennée" <alex.bennee@linaro.org>,
richard.henderson@linaro.org, f4bug@amsat.org, cota@braap.org,
stefanha@redhat.com, marcandre.lureau@redhat.com,
pbonzini@redhat.com, aurelien@aurel32.net
Subject: [PATCH v2 3/8] configure: move gettext detection to meson.build
Date: Thu, 10 Dec 2020 19:04:12 +0000 [thread overview]
Message-ID: <20201210190417.31673-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20201210190417.31673-1-alex.bennee@linaro.org>
This will allow meson to honour -Dauto_features=disabled later.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
configure | 19 +++----------------
meson_options.txt | 2 +-
po/meson.build | 2 +-
3 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/configure b/configure
index 8f2095a2db..46fdea88c7 100755
--- a/configure
+++ b/configure
@@ -448,7 +448,7 @@ libdaxctl=""
meson=""
ninja=""
skip_meson=no
-gettext=""
+gettext="auto"
bogus_os="no"
malloc_trim="auto"
@@ -1014,9 +1014,9 @@ for opt do
;;
--enable-vnc) vnc="enabled"
;;
- --disable-gettext) gettext="false"
+ --disable-gettext) gettext="disabled"
;;
- --enable-gettext) gettext="true"
+ --enable-gettext) gettext="enabled"
;;
--oss-lib=*) oss_lib="$optarg"
;;
@@ -2839,19 +2839,6 @@ if test "$xen_pci_passthrough" != "disabled"; then
fi
fi
-##########################################
-# gettext probe
-if test "$gettext" != "false" ; then
- if has xgettext; then
- gettext=true
- else
- if test "$gettext" = "true" ; then
- feature_not_found "gettext" "Install xgettext binary"
- fi
- gettext=false
- fi
-fi
-
##########################################
# X11 probe
if $pkg_config --exists "x11"; then
diff --git a/meson_options.txt b/meson_options.txt
index f6f64785fe..191e848600 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -9,7 +9,7 @@ option('sphinx_build', type : 'string', value : '',
option('docs', type : 'feature', value : 'auto',
description: 'Documentations build support')
-option('gettext', type : 'boolean', value : true,
+option('gettext', type : 'feature', value : 'auto',
description: 'Localization of the GTK+ user interface')
option('install_blobs', type : 'boolean', value : true,
description: 'install provided firmware blobs')
diff --git a/po/meson.build b/po/meson.build
index 1387fd979a..a863f0575f 100644
--- a/po/meson.build
+++ b/po/meson.build
@@ -1,6 +1,6 @@
i18n = import('i18n')
-if get_option('gettext')
+if find_program('xgettext', required: get_option('gettext')).found()
i18n.gettext(meson.project_name(),
args: '--msgid-bugs-address=qemu-devel@nongnu.org',
preset: 'glib')
--
2.20.1
next prev parent reply other threads:[~2020-12-10 19:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 19:04 [PATCH v2 0/8] testing/next (without-features, gitlab, python) Alex Bennée
2020-12-10 19:04 ` [PATCH v2 1/8] configure: include moxie-softmmu in deprecated_targets_list Alex Bennée
2020-12-11 6:18 ` Thomas Huth
2020-12-11 18:46 ` Wainer dos Santos Moschetta
2020-12-10 19:04 ` [PATCH v2 2/8] gitlab: include aarch64-softmmu and ppc64-softmmu cross-system-build Alex Bennée
2020-12-11 6:14 ` Thomas Huth
2020-12-11 18:49 ` Wainer dos Santos Moschetta
2020-12-10 19:04 ` Alex Bennée [this message]
2020-12-16 14:19 ` [PATCH v2 3/8] configure: move gettext detection to meson.build Alex Bennée
2020-12-16 14:30 ` Paolo Bonzini
2020-12-16 15:27 ` Alex Bennée
2020-12-16 15:35 ` Paolo Bonzini
2020-12-10 19:04 ` [PATCH v2 4/8] configure: add --without-default-features Alex Bennée
2020-12-11 7:53 ` Thomas Huth
2020-12-11 9:44 ` Alex Bennée
2020-12-10 19:04 ` [PATCH v2 5/8] python: add __repr__ to ConsoleSocket to aid debugging Alex Bennée
2020-12-10 19:04 ` [PATCH v2 6/8] gitlab: move --without-default-devices build from Travis Alex Bennée
2020-12-11 6:15 ` Thomas Huth
2020-12-11 18:55 ` Wainer dos Santos Moschetta
2020-12-10 19:04 ` [PATCH v2 7/8] gitlab: add --without-default-features build Alex Bennée
2020-12-11 6:16 ` Thomas Huth
2020-12-10 19:04 ` [PATCH v2 8/8] tests/tcg: build tests with -Werror Alex Bennée
2020-12-10 22:07 ` Philippe Mathieu-Daudé
2020-12-11 7:55 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210190417.31673-4-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).