qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, "Willian Rampazzo" <willianr@redhat.com>,
	berrange@redhat.com, "Eduardo Habkost" <ehabkost@redhat.com>,
	stefanb@linux.vnet.ibm.com,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	richard.henderson@linaro.org, f4bug@amsat.org,
	"John Snow" <jsnow@redhat.com>,
	cota@braap.org, stefanha@redhat.com, marcandre.lureau@redhat.com,
	pbonzini@redhat.com, aurelien@aurel32.net
Subject: [PATCH v2 5/8] python: add __repr__ to ConsoleSocket to aid debugging
Date: Thu, 10 Dec 2020 19:04:14 +0000	[thread overview]
Message-ID: <20201210190417.31673-6-alex.bennee@linaro.org> (raw)
In-Reply-To: <20201210190417.31673-1-alex.bennee@linaro.org>

While attempting to debug some console weirdness I thought it would be
worth making it easier to see what it had inside.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>

---
v2
  - make more pythonic
---
 python/qemu/console_socket.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py
index f060d79e06..ac21130e44 100644
--- a/python/qemu/console_socket.py
+++ b/python/qemu/console_socket.py
@@ -45,6 +45,13 @@ class ConsoleSocket(socket.socket):
         if drain:
             self._drain_thread = self._thread_start()
 
+    def __repr__(self) -> str:
+        s = super().__repr__()
+        s = s.rstrip(">")
+        s = "%s,  logfile=%s, drain_thread=%s>" % (s, self._logfile,
+                                                   self._drain_thread)
+        return s
+
     def _drain_fn(self) -> None:
         """Drains the socket and runs while the socket is open."""
         while self._open:
-- 
2.20.1



  parent reply	other threads:[~2020-12-10 19:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 19:04 [PATCH v2 0/8] testing/next (without-features, gitlab, python) Alex Bennée
2020-12-10 19:04 ` [PATCH v2 1/8] configure: include moxie-softmmu in deprecated_targets_list Alex Bennée
2020-12-11  6:18   ` Thomas Huth
2020-12-11 18:46   ` Wainer dos Santos Moschetta
2020-12-10 19:04 ` [PATCH v2 2/8] gitlab: include aarch64-softmmu and ppc64-softmmu cross-system-build Alex Bennée
2020-12-11  6:14   ` Thomas Huth
2020-12-11 18:49   ` Wainer dos Santos Moschetta
2020-12-10 19:04 ` [PATCH v2 3/8] configure: move gettext detection to meson.build Alex Bennée
2020-12-16 14:19   ` Alex Bennée
2020-12-16 14:30     ` Paolo Bonzini
2020-12-16 15:27       ` Alex Bennée
2020-12-16 15:35         ` Paolo Bonzini
2020-12-10 19:04 ` [PATCH v2 4/8] configure: add --without-default-features Alex Bennée
2020-12-11  7:53   ` Thomas Huth
2020-12-11  9:44     ` Alex Bennée
2020-12-10 19:04 ` Alex Bennée [this message]
2020-12-10 19:04 ` [PATCH v2 6/8] gitlab: move --without-default-devices build from Travis Alex Bennée
2020-12-11  6:15   ` Thomas Huth
2020-12-11 18:55   ` Wainer dos Santos Moschetta
2020-12-10 19:04 ` [PATCH v2 7/8] gitlab: add --without-default-features build Alex Bennée
2020-12-11  6:16   ` Thomas Huth
2020-12-10 19:04 ` [PATCH v2 8/8] tests/tcg: build tests with -Werror Alex Bennée
2020-12-10 22:07   ` Philippe Mathieu-Daudé
2020-12-11  7:55   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210190417.31673-6-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=stefanha@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).