From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Chen Qun <kuhn.chenqun@huawei.com>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH 02/12] target/unicore32/translate: Add missing fallthrough annotations
Date: Fri, 11 Dec 2020 16:24:16 +0100 [thread overview]
Message-ID: <20201211152426.350966-3-thuth@redhat.com> (raw)
In-Reply-To: <20201211152426.350966-1-thuth@redhat.com>
Looking at the way the code is formatted here (there is an empty line
after break statements, but none where the break is missing), and the
instruction set overview at https://en.wikipedia.org/wiki/Unicore the
fallthrough is very likely intended here. So add a fallthrough comment
to make the it compilable with -Werror=implicit-fallthrough.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
target/unicore32/translate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/unicore32/translate.c b/target/unicore32/translate.c
index d4b06df672..962f9877a0 100644
--- a/target/unicore32/translate.c
+++ b/target/unicore32/translate.c
@@ -1801,6 +1801,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, DisasContext *s)
do_misc(env, s, insn);
break;
}
+ /* fallthrough */
case 0x1:
if (((UCOP_OPCODES >> 2) == 2) && !UCOP_SET_S) {
do_misc(env, s, insn);
@@ -1817,6 +1818,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, DisasContext *s)
if (UCOP_SET(8) || UCOP_SET(5)) {
ILLEGAL;
}
+ /* fallthrough */
case 0x3:
do_ldst_ir(env, s, insn);
break;
--
2.27.0
next prev parent reply other threads:[~2020-12-11 15:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 15:24 [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough Thomas Huth
2020-12-11 15:24 ` [PATCH 01/12] disas/libvixl: Fix fall-through annotation for GCC >= 7 Thomas Huth
2020-12-11 15:35 ` Peter Maydell
2020-12-11 15:24 ` Thomas Huth [this message]
2020-12-11 15:24 ` [PATCH 03/12] hw/rtc/twl92230: Silence warnings about missing fallthrough statements Thomas Huth
2020-12-11 15:37 ` Peter Maydell
2020-12-11 15:24 ` [PATCH 04/12] hw/timer/renesas_tmr: silence the compiler warnings Thomas Huth
2020-12-11 15:38 ` Peter Maydell
2020-12-11 15:46 ` Thomas Huth
2020-12-11 15:24 ` [PATCH 05/12] target/i386: silence the compiler warnings in gen_shiftd_rm_T1 Thomas Huth
2020-12-11 15:24 ` [PATCH 06/12] hw/intc/arm_gicv3_kvm: silence the compiler warnings Thomas Huth
2020-12-11 15:24 ` [PATCH 07/12] accel/tcg/user-exec: " Thomas Huth
2020-12-11 15:24 ` [PATCH 08/12] target/sparc/translate: " Thomas Huth
2020-12-11 15:24 ` [PATCH 09/12] target/sparc/win_helper: " Thomas Huth
2020-12-11 15:24 ` [PATCH 10/12] tcg/optimize: Add fallthrough annotations Thomas Huth
2020-12-11 15:45 ` Richard Henderson
2020-12-11 15:24 ` [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests Thomas Huth
2020-12-11 15:46 ` Richard Henderson
2020-12-12 7:58 ` Chenqun (kuhn)
2020-12-11 15:24 ` [PATCH 12/12] configure: Compile with -Wimplicit-fallthrough=2 Thomas Huth
2020-12-11 15:42 ` Peter Maydell
2020-12-12 9:19 ` Chenqun (kuhn)
2020-12-11 15:55 ` [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough Thomas Huth
2020-12-11 17:06 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211152426.350966-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).