From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: KONRAD Frederic <frederic.konrad@adacore.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Fabien Chouteau <chouteau@adacore.com>
Subject: [PATCH 0/2] sparc/leon3: Make grlib-irqmp handle its own inbound IRQ lines
Date: Sat, 12 Dec 2020 14:41:32 +0000 [thread overview]
Message-ID: <20201212144134.29594-1-peter.maydell@linaro.org> (raw)
Currently the GRLIB_IRQMP device is used in one place (the leon3
board), but instead of the device providing inbound gpio lines for
the board to wire up, the board code itself calls
qemu_allocate_irqs() with the handler function being a set_irq
function defined in the code for the device.
Patch one in this series refactors this into the standard setup of a
device having input gpio lines. The main motivation here is that it
squashes a trivial Coverity memory leak warning. Patch two just
removes a stray unused typedef that I noticed in passing.
Incidentally I suspect the irqmp_ack logic could also be done more
neatly, but I didn't feel like getting into that at this point.
Tested by booting the 'buildroot' image downloadable from
https://www.gaisler.com/anonftp/linux/linux-2.6/images/leon-linux-4.9/leon-linux-4.9-1.0/up/
and runnable with
./build/sparc-all/qemu-system-sparc -M leon3_generic -display none -serial stdio -kernel image.ram
thanks
-- PMM
Peter Maydell (2):
hw/sparc: Make grlib-irqmp device handle its own inbound IRQ lines
include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef
include/hw/sparc/grlib.h | 4 ----
hw/intc/grlib_irqmp.c | 5 ++++-
hw/sparc/leon3.c | 21 +++++++++------------
3 files changed, 13 insertions(+), 17 deletions(-)
--
2.20.1
next reply other threads:[~2020-12-12 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-12 14:41 Peter Maydell [this message]
2020-12-12 14:41 ` [PATCH 1/2] hw/sparc: Make grlib-irqmp device handle its own inbound IRQ lines Peter Maydell
2020-12-13 12:08 ` Philippe Mathieu-Daudé
2021-01-05 13:15 ` Fred Konrad
2020-12-12 14:41 ` [PATCH 2/2] include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef Peter Maydell
2020-12-13 12:05 ` Philippe Mathieu-Daudé
2021-01-05 13:15 ` Fred Konrad
2021-01-05 13:04 ` [PATCH 0/2] sparc/leon3: Make grlib-irqmp handle its own inbound IRQ lines Mark Cave-Ayland
2021-01-05 13:17 ` Fred Konrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201212144134.29594-1-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=atar4qemu@gmail.com \
--cc=chouteau@adacore.com \
--cc=frederic.konrad@adacore.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).