From: "Volker Rümelin" <vr_qemu@t-online.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: [PATCH 2/4] coreaudio: don't start playback in init routine
Date: Sun, 13 Dec 2020 14:05:26 +0100 [thread overview]
Message-ID: <20201213130528.5863-2-vr_qemu@t-online.de> (raw)
In-Reply-To: <1a970310-4cff-f2f7-985e-05b2f4cd446b@t-online.de>
Every emulated audio device has a way to enable audio playback. Don't
start playback until the guest enables the audio device to keep the
Core Audio device run state in sync with hw->enabled.
Tested-by: Howard Spoelstra <hsp.cat7@gmail.com>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
audio/coreaudio.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/audio/coreaudio.c b/audio/coreaudio.c
index 0ee85052c4..a5df950514 100644
--- a/audio/coreaudio.c
+++ b/audio/coreaudio.c
@@ -584,17 +584,6 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,
return -1;
}
- /* start Playback */
- if (!isPlaying(core->outputDeviceID)) {
- status = AudioDeviceStart(core->outputDeviceID, core->ioprocid);
- if (status != kAudioHardwareNoError) {
- coreaudio_logerr2 (status, typ, "Could not start playback\n");
- AudioDeviceDestroyIOProcID(core->outputDeviceID, core->ioprocid);
- core->outputDeviceID = kAudioDeviceUnknown;
- return -1;
- }
- }
-
return 0;
}
--
2.26.2
next prev parent reply other threads:[~2020-12-13 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 13:03 [PATCH 0/4] coreaudio bug fix and clean up Volker Rümelin
2020-12-13 13:05 ` [PATCH 1/4] coreaudio: rename misnamed variable fake_as Volker Rümelin
2020-12-15 8:16 ` Gerd Hoffmann
2020-12-13 13:05 ` Volker Rümelin [this message]
2020-12-13 13:05 ` [PATCH 3/4] coreaudio: always stop audio playback on shut down Volker Rümelin
2020-12-13 13:05 ` [PATCH 4/4] audio: remove unused function audio_is_cleaning_up() Volker Rümelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201213130528.5863-2-vr_qemu@t-online.de \
--to=vr_qemu@t-online.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).