From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Marek Vasut" <marex@denx.de>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Chris Wulff" <crwulff@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v1 4/6] gdbstub: drop CPUEnv from gdb_exit()
Date: Mon, 14 Dec 2020 15:30:10 +0000 [thread overview]
Message-ID: <20201214153012.12723-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20201214153012.12723-1-alex.bennee@linaro.org>
gdb_exit() has never needed anything from env and I doubt we are going
to start now.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
include/exec/gdbstub.h | 2 +-
bsd-user/syscall.c | 6 +++---
gdbstub.c | 2 +-
linux-user/exit.c | 2 +-
target/arm/arm-semi.c | 2 +-
target/m68k/m68k-semi.c | 2 +-
target/nios2/nios2-semi.c | 2 +-
7 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h
index 94d8f83e92..492db0f512 100644
--- a/include/exec/gdbstub.h
+++ b/include/exec/gdbstub.h
@@ -46,7 +46,7 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const char *fmt, ...);
void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va);
int use_gdb_syscalls(void);
void gdb_set_stop_cpu(CPUState *cpu);
-void gdb_exit(CPUArchState *, int);
+void gdb_exit(int);
#ifdef CONFIG_USER_ONLY
/**
* gdb_handlesig: yield control to gdb
diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c
index d38ec7a162..adc3d21b54 100644
--- a/bsd-user/syscall.c
+++ b/bsd-user/syscall.c
@@ -333,7 +333,7 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, abi_long arg1,
#ifdef CONFIG_GPROF
_mcleanup();
#endif
- gdb_exit(cpu_env, arg1);
+ gdb_exit(arg1);
qemu_plugin_atexit_cb();
/* XXX: should free thread stack and CPU env */
_exit(arg1);
@@ -435,7 +435,7 @@ abi_long do_netbsd_syscall(void *cpu_env, int num, abi_long arg1,
#ifdef CONFIG_GPROF
_mcleanup();
#endif
- gdb_exit(cpu_env, arg1);
+ gdb_exit(arg1);
qemu_plugin_atexit_cb();
/* XXX: should free thread stack and CPU env */
_exit(arg1);
@@ -514,7 +514,7 @@ abi_long do_openbsd_syscall(void *cpu_env, int num, abi_long arg1,
#ifdef CONFIG_GPROF
_mcleanup();
#endif
- gdb_exit(cpu_env, arg1);
+ gdb_exit(arg1);
qemu_plugin_atexit_cb();
/* XXX: should free thread stack and CPU env */
_exit(arg1);
diff --git a/gdbstub.c b/gdbstub.c
index ec8daa002b..f6566c7b82 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -3068,7 +3068,7 @@ static void gdb_read_byte(uint8_t ch)
}
/* Tell the remote gdb that the process has exited. */
-void gdb_exit(CPUArchState *env, int code)
+void gdb_exit(int code)
{
char buf[4];
diff --git a/linux-user/exit.c b/linux-user/exit.c
index 1594015444..70b344048c 100644
--- a/linux-user/exit.c
+++ b/linux-user/exit.c
@@ -34,6 +34,6 @@ void preexit_cleanup(CPUArchState *env, int code)
#ifdef CONFIG_GCOV
__gcov_dump();
#endif
- gdb_exit(env, code);
+ gdb_exit(code);
qemu_plugin_atexit_cb();
}
diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c
index c892e0e674..5d5654bec0 100644
--- a/target/arm/arm-semi.c
+++ b/target/arm/arm-semi.c
@@ -1100,7 +1100,7 @@ target_ulong do_arm_semihosting(CPUARMState *env)
*/
ret = (args == ADP_Stopped_ApplicationExit) ? 0 : 1;
}
- gdb_exit(env, ret);
+ gdb_exit(ret);
exit(ret);
case TARGET_SYS_SYNCCACHE:
/*
diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
index 8e5fbfc8fa..6230a789b6 100644
--- a/target/m68k/m68k-semi.c
+++ b/target/m68k/m68k-semi.c
@@ -194,7 +194,7 @@ void do_m68k_semihosting(CPUM68KState *env, int nr)
args = env->dregs[1];
switch (nr) {
case HOSTED_EXIT:
- gdb_exit(env, env->dregs[0]);
+ gdb_exit(env->dregs[0]);
exit(env->dregs[0]);
case HOSTED_OPEN:
GET_ARG(0);
diff --git a/target/nios2/nios2-semi.c b/target/nios2/nios2-semi.c
index d7a80dd303..e508b2fafc 100644
--- a/target/nios2/nios2-semi.c
+++ b/target/nios2/nios2-semi.c
@@ -215,7 +215,7 @@ void do_nios2_semihosting(CPUNios2State *env)
args = env->regs[R_ARG1];
switch (nr) {
case HOSTED_EXIT:
- gdb_exit(env, env->regs[R_ARG0]);
+ gdb_exit(env->regs[R_ARG0]);
exit(env->regs[R_ARG0]);
case HOSTED_OPEN:
GET_ARG(0);
--
2.20.1
next prev parent reply other threads:[~2020-12-14 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 15:30 [PATCH v1 0/6] gdbstub (auxv, tests, cleanup) Alex Bennée
2020-12-14 15:30 ` [PATCH v1 1/6] test/guest-debug: echo QEMU command as well Alex Bennée
2020-12-14 15:30 ` [PATCH v1 2/6] configure: gate our use of GDB to 8.3.1 or above Alex Bennée
2020-12-14 15:47 ` Peter Maydell
2020-12-14 17:05 ` Alex Bennée
2020-12-14 17:14 ` Peter Maydell
2020-12-14 15:30 ` [PATCH v1 3/6] gdbstub: add support to Xfer:auxv:read: packet Alex Bennée
2020-12-16 19:54 ` Richard Henderson
2020-12-14 15:30 ` Alex Bennée [this message]
2020-12-16 19:55 ` [PATCH v1 4/6] gdbstub: drop CPUEnv from gdb_exit() Richard Henderson
2020-12-14 15:30 ` [PATCH v1 5/6] gdbstub: drop gdbserver_cleanup in favour of gdb_exit Alex Bennée
2020-12-16 19:56 ` Richard Henderson
2020-12-14 15:30 ` [PATCH v1 6/6] gdbstub: ensure we clean-up when terminated Alex Bennée
2020-12-16 19:56 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214153012.12723-5-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=crwulff@gmail.com \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).