qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH  v1 6/6] gdbstub: ensure we clean-up when terminated
Date: Mon, 14 Dec 2020 15:30:12 +0000	[thread overview]
Message-ID: <20201214153012.12723-7-alex.bennee@linaro.org> (raw)
In-Reply-To: <20201214153012.12723-1-alex.bennee@linaro.org>

If you kill the inferior from GDB we end up leaving our socket lying
around. Fix this by calling gdb_exit() first.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 gdbstub.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdbstub.c b/gdbstub.c
index 7172f063a1..61fe2360e3 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1978,6 +1978,7 @@ static void handle_v_kill(GdbCmdContext *gdb_ctx, void *user_ctx)
     /* Kill the target */
     put_packet("OK");
     error_report("QEMU: Terminated via GDBstub");
+    gdb_exit(0);
     exit(0);
 }
 
@@ -2539,6 +2540,7 @@ static int gdb_handle_packet(const char *line_buf)
     case 'k':
         /* Kill the target */
         error_report("QEMU: Terminated via GDBstub");
+        gdb_exit(0);
         exit(0);
     case 'D':
         {
-- 
2.20.1



  parent reply	other threads:[~2020-12-14 15:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 15:30 [PATCH v1 0/6] gdbstub (auxv, tests, cleanup) Alex Bennée
2020-12-14 15:30 ` [PATCH v1 1/6] test/guest-debug: echo QEMU command as well Alex Bennée
2020-12-14 15:30 ` [PATCH v1 2/6] configure: gate our use of GDB to 8.3.1 or above Alex Bennée
2020-12-14 15:47   ` Peter Maydell
2020-12-14 17:05     ` Alex Bennée
2020-12-14 17:14       ` Peter Maydell
2020-12-14 15:30 ` [PATCH v1 3/6] gdbstub: add support to Xfer:auxv:read: packet Alex Bennée
2020-12-16 19:54   ` Richard Henderson
2020-12-14 15:30 ` [PATCH v1 4/6] gdbstub: drop CPUEnv from gdb_exit() Alex Bennée
2020-12-16 19:55   ` Richard Henderson
2020-12-14 15:30 ` [PATCH v1 5/6] gdbstub: drop gdbserver_cleanup in favour of gdb_exit Alex Bennée
2020-12-16 19:56   ` Richard Henderson
2020-12-14 15:30 ` Alex Bennée [this message]
2020-12-16 19:56   ` [PATCH v1 6/6] gdbstub: ensure we clean-up when terminated Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214153012.12723-7-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).