From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF76AC4361B for ; Mon, 14 Dec 2020 14:59:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F0E12253A for ; Mon, 14 Dec 2020 14:59:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F0E12253A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kopJd-0004z7-CH for qemu-devel@archiver.kernel.org; Mon, 14 Dec 2020 09:59:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kopIN-0004Bc-Fd for qemu-devel@nongnu.org; Mon, 14 Dec 2020 09:57:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:21032) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kopIL-0001qm-SL for qemu-devel@nongnu.org; Mon, 14 Dec 2020 09:57:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607957868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b094AQo4+p6gPw7hew5xnCRZ53j4BdqKi+MDnoMtnhA=; b=AGCZHPasv/ecMXMGhjQUEuG9ujJmwilwGhAtLotZmLyczSRJs0eDeoT+63hv+MdygmUTQN 5Ioih0O7xAhDBJDAZIhDBnG0UpyVXLmf69dsaBbt8GcQwHKzoxKq9OK0H5T9Rnrv2ROr/a Ebct8QDQTDwwvUazqrj3j9iqmt31B0s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-84-kP4CGCj7PJGBIDbkl0i5kA-1; Mon, 14 Dec 2020 09:57:47 -0500 X-MC-Unique: kP4CGCj7PJGBIDbkl0i5kA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B2EF80400D; Mon, 14 Dec 2020 14:57:46 +0000 (UTC) Received: from localhost (unknown [10.40.208.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF6DD1042A88; Mon, 14 Dec 2020 14:57:39 +0000 (UTC) Date: Mon, 14 Dec 2020 15:57:37 +0100 From: Igor Mammedov To: Eduardo Habkost Subject: Re: [PATCH v4 24/32] qdev: Make PropertyInfo.create return ObjectProperty* Message-ID: <20201214155737.514548b7@redhat.com> In-Reply-To: <20201211220529.2290218-25-ehabkost@redhat.com> References: <20201211220529.2290218-1-ehabkost@redhat.com> <20201211220529.2290218-25-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Daniel P. Berrange" , John Snow , qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 11 Dec 2020 17:05:21 -0500 Eduardo Habkost wrote: > Returning ObjectProperty* will be useful for new property > registration code that will add additional callbacks > to ObjectProperty after registering it. >=20 > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Changes v1 -> v2: > * Redone patch on top of additional changes in series v2 > * Commit message reword > --- > Cc: Paolo Bonzini > Cc: "Daniel P. Berrang=C3=A9" > Cc: Eduardo Habkost > Cc: qemu-devel@nongnu.org > --- > include/hw/qdev-properties.h | 3 ++- > hw/core/qdev-properties.c | 12 ++++++------ > 2 files changed, 8 insertions(+), 7 deletions(-) >=20 > diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h > index ab9c538ba4..aae882317a 100644 > --- a/include/hw/qdev-properties.h > +++ b/include/hw/qdev-properties.h > @@ -34,7 +34,8 @@ struct PropertyInfo { > const QEnumLookup *enum_table; > int (*print)(Object *obj, Property *prop, char *dest, size_t len); > void (*set_default_value)(ObjectProperty *op, const Property *prop); > - void (*create)(ObjectClass *oc, const char *name, Property *prop); > + ObjectProperty *(*create)(ObjectClass *oc, const char *name, > + Property *prop); > ObjectPropertyAccessor *get; > ObjectPropertyAccessor *set; > ObjectPropertyRelease *release; > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c > index 92f48ecbf2..3bb05e7d0d 100644 > --- a/hw/core/qdev-properties.c > +++ b/hw/core/qdev-properties.c > @@ -821,13 +821,13 @@ const PropertyInfo qdev_prop_size =3D { > =20 > /* --- object link property --- */ > =20 > -static void create_link_property(ObjectClass *oc, const char *name, > - Property *prop) > +static ObjectProperty *create_link_property(ObjectClass *oc, const char = *name, > + Property *prop) > { > - object_class_property_add_link(oc, name, prop->link_type, > - prop->offset, > - qdev_prop_allow_set_link_before_reali= ze, > - OBJ_PROP_LINK_STRONG); > + return object_class_property_add_link(oc, name, prop->link_type, > + prop->offset, > + qdev_prop_allow_set_link_befor= e_realize, > + OBJ_PROP_LINK_STRONG); > } > =20 > const PropertyInfo qdev_prop_link =3D {