qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: marcandre.lureau@redhat.com
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Paul Durrant <paul@xen.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
	qemu-arm@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org, philmd@redhat.com,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v3 01/13] qemu/atomic: Drop special case for unsupported compiler
Date: Mon, 14 Dec 2020 16:56:50 +0000	[thread overview]
Message-ID: <20201214165650.GG620320@stefanha-x1.localdomain> (raw)
In-Reply-To: <20201210134752.780923-2-marcandre.lureau@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

On Thu, Dec 10, 2020 at 05:47:40PM +0400, marcandre.lureau@redhat.com wrote:
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> Since commit efc6c070aca ("configure: Add a test for the
> minimum compiler version") the minimum compiler version
> required for GCC is 4.8, which has the GCC BZ#36793 bug fixed.
> 
> We can safely remove the special case introduced in commit
> a281ebc11a6 ("virtio: add missing mb() on notification").
> 
> With clang 3.4, __ATOMIC_RELAXED is defined, so the chunk to
> remove (which is x86-specific), isn't reached either.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  include/qemu/atomic.h | 17 -----------------
>  1 file changed, 17 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-12-14 16:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 13:47 [PATCH v3 00/13] Remove GCC < 4.8 checks marcandre.lureau
2020-12-10 13:47 ` [PATCH v3 01/13] qemu/atomic: Drop special case for unsupported compiler marcandre.lureau
2020-12-14 16:56   ` Stefan Hajnoczi [this message]
2020-12-10 13:47 ` [PATCH v3 02/13] accel/tcg: Remove special case for GCC < 4.6 marcandre.lureau
2020-12-10 13:47 ` [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback marcandre.lureau
2020-12-10 14:32   ` Philippe Mathieu-Daudé
2020-12-10 14:46     ` Peter Maydell
2020-12-10 14:55       ` Marc-André Lureau
2020-12-14 10:17     ` Paolo Bonzini
2020-12-10 13:47 ` [PATCH v3 04/13] qemu-plugin.h: remove GCC < 4 marcandre.lureau
2020-12-10 13:47 ` [PATCH v3 05/13] tests: remove GCC < 4 fallbacks marcandre.lureau
2020-12-10 13:47 ` [PATCH v3 06/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON marcandre.lureau
2020-12-11 20:11   ` Dr. David Alan Gilbert
2020-12-14 16:57   ` Stefan Hajnoczi
2020-12-10 13:47 ` [PATCH v3 07/13] compiler.h: explicit case for Clang printf attribute marcandre.lureau
2020-12-11  4:20   ` Michael Tokarev
2020-12-10 13:47 ` [PATCH v3 08/13] audio: remove GNUC & MSVC check marcandre.lureau
2020-12-10 14:26   ` Philippe Mathieu-Daudé
2020-12-10 14:27     ` Peter Maydell
2020-12-10 14:34       ` Philippe Mathieu-Daudé
2020-12-10 14:56         ` Marc-André Lureau
2020-12-10 13:47 ` [PATCH v3 09/13] poison: remove GNUC check marcandre.lureau
2020-12-10 14:27   ` Philippe Mathieu-Daudé
2020-12-10 13:47 ` [PATCH v3 10/13] xen: " marcandre.lureau
2020-12-10 13:47 ` [PATCH v3 11/13] compiler: " marcandre.lureau
2020-12-12 13:53   ` Marc-André Lureau
2020-12-12 14:00   ` Peter Maydell
2020-12-10 13:47 ` [PATCH v3 12/13] linux-user: " marcandre.lureau
2020-12-10 14:27   ` Philippe Mathieu-Daudé
2020-12-10 13:47 ` [PATCH v3 13/13] compiler.h: remove QEMU_GNUC_PREREQ marcandre.lureau
2020-12-14  8:05   ` Marc-André Lureau
2020-12-10 13:57 ` [PATCH v3 00/13] Remove GCC < 4.8 checks no-reply
2020-12-14 10:20 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214165650.GG620320@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=dgilbert@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=marcandre.lureau@redhat.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).