From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: [PULL 5/7] cs4231: Get rid of empty property array
Date: Tue, 15 Dec 2020 14:48:24 +0100 [thread overview]
Message-ID: <20201215134826.5504-6-kraxel@redhat.com> (raw)
In-Reply-To: <20201215134826.5504-1-kraxel@redhat.com>
From: Eduardo Habkost <ehabkost@redhat.com>
An empty props array is unnecessary, we can just not call
device_class_set_props().
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-id: 20201211220529.2290218-2-ehabkost@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/audio/cs4231.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/audio/cs4231.c b/hw/audio/cs4231.c
index 8e9554ce9bcd..209c05a0a0d5 100644
--- a/hw/audio/cs4231.c
+++ b/hw/audio/cs4231.c
@@ -160,17 +160,12 @@ static void cs4231_init(Object *obj)
sysbus_init_irq(dev, &s->irq);
}
-static Property cs4231_properties[] = {
- {.name = NULL},
-};
-
static void cs4231_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
dc->reset = cs_reset;
dc->vmsd = &vmstate_cs4231;
- device_class_set_props(dc, cs4231_properties);
}
static const TypeInfo cs4231_info = {
--
2.27.0
next prev parent reply other threads:[~2020-12-15 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 13:48 [PULL 0/7] Audio 20201215 patches Gerd Hoffmann
2020-12-15 13:48 ` [PULL 1/7] coreaudio: rename misnamed variable fake_as Gerd Hoffmann
2020-12-15 13:48 ` [PULL 2/7] coreaudio: don't start playback in init routine Gerd Hoffmann
2020-12-15 13:48 ` [PULL 3/7] coreaudio: always stop audio playback on shut down Gerd Hoffmann
2020-12-15 13:48 ` [PULL 4/7] audio: remove unused function audio_is_cleaning_up() Gerd Hoffmann
2020-12-15 13:48 ` Gerd Hoffmann [this message]
2020-12-15 13:48 ` [PULL 6/7] audio: Simplify audio_bug() removing old code Gerd Hoffmann
2020-12-15 13:48 ` [PULL 7/7] audio: add sanity check Gerd Hoffmann
2020-12-15 15:35 ` [PULL 0/7] Audio 20201215 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215134826.5504-6-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).