From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: dann frazier <dann.frazier@canonical.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [PULL 7/7] audio: add sanity check
Date: Tue, 15 Dec 2020 14:48:26 +0100 [thread overview]
Message-ID: <20201215134826.5504-8-kraxel@redhat.com> (raw)
In-Reply-To: <20201215134826.5504-1-kraxel@redhat.com>
Check whenever we actually found the spiceaudio driver
before flipping the can_be_default field.
Fixes: f0c4555edfdd ("audio: remove qemu_spice_audio_init()")
Buglink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977301
Reported-by: dann frazier <dann.frazier@canonical.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20201215081151.20095-1-kraxel@redhat.com>
---
audio/audio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/audio/audio.c b/audio/audio.c
index 0fdb808d6a57..b48471bb3f64 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1684,7 +1684,9 @@ static AudioState *audio_init(Audiodev *dev, const char *name)
* backend and this can go away.
*/
driver = audio_driver_lookup("spice");
- driver->can_be_default = 1;
+ if (driver) {
+ driver->can_be_default = 1;
+ }
}
if (dev) {
--
2.27.0
next prev parent reply other threads:[~2020-12-15 13:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 13:48 [PULL 0/7] Audio 20201215 patches Gerd Hoffmann
2020-12-15 13:48 ` [PULL 1/7] coreaudio: rename misnamed variable fake_as Gerd Hoffmann
2020-12-15 13:48 ` [PULL 2/7] coreaudio: don't start playback in init routine Gerd Hoffmann
2020-12-15 13:48 ` [PULL 3/7] coreaudio: always stop audio playback on shut down Gerd Hoffmann
2020-12-15 13:48 ` [PULL 4/7] audio: remove unused function audio_is_cleaning_up() Gerd Hoffmann
2020-12-15 13:48 ` [PULL 5/7] cs4231: Get rid of empty property array Gerd Hoffmann
2020-12-15 13:48 ` [PULL 6/7] audio: Simplify audio_bug() removing old code Gerd Hoffmann
2020-12-15 13:48 ` Gerd Hoffmann [this message]
2020-12-15 15:35 ` [PULL 0/7] Audio 20201215 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215134826.5504-8-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=dann.frazier@canonical.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).