From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Luc Michel" <luc.michel@greensocs.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH v2 0/4] clock: Get rid of clock_get_ns()
Date: Tue, 15 Dec 2020 15:09:25 +0000 [thread overview]
Message-ID: <20201215150929.30311-1-peter.maydell@linaro.org> (raw)
This patchseries makes some changes to the clock API:
* Remove clock_get_ns()
* Add clock_ticks_to_ns() to return number of nanoseconds
it will take the clock to tick N times
* clock_display_freq() to return prettily-formatted string
for showing humans the approximate clock frequency
This is based on discussions we had about these APIs a little while
back. The core driver here is that the clock objects internally
store the period in units of 2^-32 ns, so both clock_get_ns() and
clock_get_hz() are inherently returning a rounded-off result, which
can be badly inaccurate for fast clocks or if you want to multiply it
by a large tick count.
Ideally I'd like to get rid of clock_get_hz() as well, but
that looks trickier than handling clock_get_ns().
Patch 4 borrows a lot of the concept from one of Philippe's that he
sent out previously.
NB: tested with 'make check' and 'make check-acceptance' only.
Changes v1->v2:
* In patch 1, saturate return value to INT64_MAX (and update
docs to explain this and why)
Patches 2-4 have been reviewed, only patch 1 needs review.
thanks
-- PMM
Peter Maydell (4):
clock: Introduce clock_ticks_to_ns()
target/mips: Don't use clock_get_ns() in clock period calculation
clock: Remove clock_get_ns()
clock: Define and use new clock_display_freq()
docs/devel/clocks.rst | 51 ++++++++++++++++++++++++++++++++++++----
include/hw/clock.h | 53 +++++++++++++++++++++++++++++++++++++++---
hw/core/clock.c | 6 +++++
softmmu/qdev-monitor.c | 6 ++---
target/mips/cpu.c | 4 ++--
5 files changed, 108 insertions(+), 12 deletions(-)
--
2.20.1
next reply other threads:[~2020-12-15 15:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 15:09 Peter Maydell [this message]
2020-12-15 15:09 ` [PATCH v2 1/4] clock: Introduce clock_ticks_to_ns() Peter Maydell
2020-12-15 15:21 ` Richard Henderson
2020-12-15 19:48 ` Luc Michel
2020-12-15 15:09 ` [PATCH v2 2/4] target/mips: Don't use clock_get_ns() in clock period calculation Peter Maydell
2020-12-15 15:09 ` [PATCH v2 3/4] clock: Remove clock_get_ns() Peter Maydell
2020-12-15 15:09 ` [PATCH v2 4/4] clock: Define and use new clock_display_freq() Peter Maydell
2020-12-15 15:29 ` [PATCH v2 0/4] clock: Get rid of clock_get_ns() Philippe Mathieu-Daudé
2020-12-15 23:08 ` Philippe Mathieu-Daudé
2021-01-01 20:35 ` Philippe Mathieu-Daudé
2021-01-03 13:47 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215150929.30311-1-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=f4bug@amsat.org \
--cc=jiaxun.yang@flygoat.com \
--cc=luc.michel@greensocs.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).