qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>
Subject: [PATCH v2 2/4] scripts/coccinelle: New script to remove unnecessary timer_del() calls
Date: Tue, 15 Dec 2020 15:41:05 +0000	[thread overview]
Message-ID: <20201215154107.3255-3-peter.maydell@linaro.org> (raw)
In-Reply-To: <20201215154107.3255-1-peter.maydell@linaro.org>

Now that timer_free() implicitly calls timer_del(), sequences
  timer_del(mytimer);
  timer_free(mytimer);

can be simplified to just
  timer_free(mytimer);


Add a Coccinelle script to do this transformation.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/coccinelle/timer-del-timer-free.cocci | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 scripts/coccinelle/timer-del-timer-free.cocci

diff --git a/scripts/coccinelle/timer-del-timer-free.cocci b/scripts/coccinelle/timer-del-timer-free.cocci
new file mode 100644
index 00000000000..c3cfd428039
--- /dev/null
+++ b/scripts/coccinelle/timer-del-timer-free.cocci
@@ -0,0 +1,18 @@
+// Remove superfluous timer_del() calls
+//
+// Copyright Linaro Limited 2020
+// This work is licensed under the terms of the GNU GPLv2 or later.
+//
+// spatch --macro-file scripts/cocci-macro-file.h \
+//        --sp-file scripts/coccinelle/timer-del-timer-free.cocci \
+//        --in-place --dir .
+//
+// The timer_free() function now implicitly calls timer_del()
+// for you, so calls to timer_del() immediately before the
+// timer_free() of the same timer can be deleted.
+
+@@
+expression T;
+@@
+-timer_del(T);
+ timer_free(T);
-- 
2.20.1



  parent reply	other threads:[~2020-12-15 15:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 15:41 [PATCH v2 0/4] qemu-timer: Make timer_free() imply timer_del() Peter Maydell
2020-12-15 15:41 ` [PATCH v2 1/4] util/qemu-timer: " Peter Maydell
2020-12-15 15:54   ` Richard Henderson
2020-12-15 15:41 ` Peter Maydell [this message]
2020-12-15 15:55   ` [PATCH v2 2/4] scripts/coccinelle: New script to remove unnecessary timer_del() calls Richard Henderson
2020-12-15 15:41 ` [PATCH v2 3/4] Remove superfluous " Peter Maydell
2020-12-15 15:41 ` [PATCH v2 4/4] target/arm: Remove timer_del()/timer_deinit() before timer_free() Peter Maydell
2020-12-15 15:54   ` Richard Henderson
2021-01-05 10:54 ` [PATCH v2 0/4] qemu-timer: Make timer_free() imply timer_del() Philippe Mathieu-Daudé
2021-01-07 21:18 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201215154107.3255-3-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).