From: Kevin Wolf <kwolf@redhat.com>
To: David Edmondson <david.edmondson@oracle.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] block: report errno when flock fcntl fails
Date: Wed, 16 Dec 2020 12:29:40 +0100 [thread overview]
Message-ID: <20201216112940.GB7548@merkur.fritz.box> (raw)
In-Reply-To: <20201215190127.1765595-1-david.edmondson@oracle.com>
Am 15.12.2020 um 20:01 hat David Edmondson geschrieben:
> When a call to fcntl(2) for the purpose of manipulating file locks
> fails, report the error returned by fcntl.
>
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
Is appending "Resource temporarily unavailable" in the common case (a
file locked by another process) actually an improvement for the message
or more confusing? It would be good to mention the motivation for the
change in the commit message.
Either way, this breaks some qemu-iotests cases whose reference output
needs to be updated.
Kevin
next prev parent reply other threads:[~2020-12-16 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 19:01 [PATCH] block: report errno when flock fcntl fails David Edmondson
2020-12-16 6:23 ` Vladimir Sementsov-Ogievskiy
2020-12-16 11:29 ` Kevin Wolf [this message]
2020-12-16 11:38 ` David Edmondson
2020-12-16 11:57 ` Kevin Wolf
2020-12-16 13:06 ` David Edmondson
2020-12-16 13:53 ` Kevin Wolf
2020-12-16 14:25 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216112940.GB7548@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).