From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67949C4361B for ; Wed, 16 Dec 2020 20:50:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0B53233EB for ; Wed, 16 Dec 2020 20:50:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0B53233EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpdl8-0004In-EB for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 15:50:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpdik-0002oG-UC for qemu-devel@nongnu.org; Wed, 16 Dec 2020 15:48:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpdij-0004Mi-00 for qemu-devel@nongnu.org; Wed, 16 Dec 2020 15:48:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608151703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9n8M2ce9XuOwDa00NO6YtkIm7X0n60lrDnzJNFtdfiM=; b=AWRF8ezOLIBIk7z/LJ1pKBXOiT71F8E575HFNILbyBe21jrtgAVjR6rPjWjVE6xY2g5BfH Ot9fcLV/VsuN7Xr5pFMBeeoYMngaeJr3TynmsBhgwa8lnansgDMuhLwsWpA+mDcaHkPh8A z4grcfmjwUvicx5upImhU+Pn/QGrpmo= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-224-H7FXu09lMn-Zs0nVOhd1Pg-1; Wed, 16 Dec 2020 15:48:21 -0500 X-MC-Unique: H7FXu09lMn-Zs0nVOhd1Pg-1 Received: by mail-qv1-f69.google.com with SMTP id 102so18754616qva.0 for ; Wed, 16 Dec 2020 12:48:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9n8M2ce9XuOwDa00NO6YtkIm7X0n60lrDnzJNFtdfiM=; b=XYmOdUUW05iwVvWuX9xquhsh1mVbu/McHIRF+rciEmRTQcyB83S5AJ07wq91rZBEWi hyvuCaXPMYET7T7BJUeA5crQ9q13CWvt9wmW3mETh88BKqnQkINn9zh55F+vxH2SKMPJ rSOoZXFs9yZzj/lfEm2Q0UtqZGkKD2TXNqnj9zXVtHBX01lq1UtFFXlbYpBHF1P3nTdq NPFyDJfNT+RM1g838o6k6zZY6mk9v/B7WZW9aez+tTKL0RZOKZ72MU+8ZtEGdRp5WxFQ CSbFiZrGYXOenbiHHhjvGbk6ge5efGx6YZN8wNFEej33dwezAnxAAi9SRbZb3ECyAMHp ZCtA== X-Gm-Message-State: AOAM530s5AcjUTqLENb7kkD8aeuVXvbToe4AVHWih9Q5Oq55Dl8/FMHL REifR47dj4u4GycIACfGAINewMHyH6eINwUZKBqBrg1VsxBEQ/2GmYWpPogDtojGQduGbHPIOlO 5GTGyQZ6iPRLM5TQ= X-Received: by 2002:ad4:5187:: with SMTP id b7mr20491897qvp.2.1608151700945; Wed, 16 Dec 2020 12:48:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJzq3oPhLxgX8ceYKEYT+D+VeCALRHmB6EAGN52tcZasWI0TCGLwWbeSg/uu9gWeHSyOWm3vnA== X-Received: by 2002:ad4:5187:: with SMTP id b7mr20491884qvp.2.1608151700786; Wed, 16 Dec 2020 12:48:20 -0800 (PST) Received: from xz-x1 ([142.126.83.202]) by smtp.gmail.com with ESMTPSA id f22sm1882194qkl.65.2020.12.16.12.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 12:48:19 -0800 (PST) Date: Wed, 16 Dec 2020 15:48:18 -0500 From: Peter Xu To: Keqian Zhu Subject: Re: [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size Message-ID: <20201216204818.GA39844@xz-x1> References: <20201215071948.23940-1-zhukeqian1@huawei.com> <20201215071948.23940-2-zhukeqian1@huawei.com> <20201215175719.GA112585@xz-x1> <8a23c62d-1167-d005-e98b-14507e15fbf2@huawei.com> MIME-Version: 1.0 In-Reply-To: <8a23c62d-1167-d005-e98b-14507e15fbf2@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , jiangkunkun@huawei.com, qemu-devel@nongnu.org, "Dr . David Alan Gilbert" , qemu-arm@nongnu.org, Paolo Bonzini , Zenghui Yu , wanghaibin.wang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Dec 16, 2020 at 04:21:17PM +0800, Keqian Zhu wrote: > One more thing, we should consider whether @start and @size is psize aligned (my second > patch). Do you agree to add assert on them directly? Yes I think the 2nd patch is okay, but please address Drew's comments. Returning -EINVAL is the same as abort() currently - it'll just abort() at kvm_log_clear() instead. Thanks, -- Peter Xu