From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7FCC4361B for ; Thu, 17 Dec 2020 09:15:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73BAE2389B for ; Thu, 17 Dec 2020 09:15:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73BAE2389B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kppNa-0007bX-Un for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 04:15:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kppMO-00073z-EB for qemu-devel@nongnu.org; Thu, 17 Dec 2020 04:14:08 -0500 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:36827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kppMM-0006ew-PC for qemu-devel@nongnu.org; Thu, 17 Dec 2020 04:14:08 -0500 Received: by mail-ej1-x62e.google.com with SMTP id lt17so36817127ejb.3 for ; Thu, 17 Dec 2020 01:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LfsOLhAWMVJ2deCuay3ook5aFVWeXApOj+vJo+lp9yU=; b=RVeWqM+sSa/0ckyCm4aqpCfGURUDlJSm5UNmK31t6IVy6urfWYqWDqUFKvAkhg0VfD YOSj6C4jVixKY1nK+KPE3bnxA7vg/eBu112ZYCundEmn6jPhGKaepd5ZD/zX6K67IJ8R RAQAK8YQhkjVWfFwFCRpU4D2FuzK01AFx7aqjaIM6UYX6hzdUmgsBUUIgi3Y+em1Thst ugHFcigFNdHQ+JihGIWskR+wf4lX8ucu+2OGQ6t7ZT1bjEMBxiTBuJlPr+EvfCn8EAu0 tbi2cVIxaM1lodevrjQD3ywl3LAAH43Cf9IHa9k0e9S/u1TaBc77Hf0uK1xLdTJVUkLD O3zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=LfsOLhAWMVJ2deCuay3ook5aFVWeXApOj+vJo+lp9yU=; b=R9ChzKy4ABUTUIFF1Pg0nG42Hfsd1Mo8xA3iYzEgDv76Tedi3ZVBXt+PiPqA6XQj5u f42o7xdiD5Ua3NsphlL1dnh3dersE/GSb4Sxohox7w0l9SBjLab+tVHHhvmXYkxUmcPE weTkXkA43k70+dA5rv/DQgZIViow4veATc8mIDYKSmwAzilUbqi62vPto7xQP+N2pCh3 nISydw2ypJuE5ovR3ZMcfuOS5hzlImkRu9DGgcscKtkDNDwMSc0+KTWs6M4FBqDCUIrw aHI51Hpvwry+R4SiU/Msyd+SP0IGuHx9TQ/gSe1I3UOJJ4BkIAewD6rCFAtYJNGiryho YFwA== X-Gm-Message-State: AOAM533BnxR97AIr9TZVoM1EDfa7bXiMjU2i3USJ8UVdMfdmh9wsfXrW ZMXJbXvnok2xaDkdAGfo5Y6JwGCJWAs= X-Google-Smtp-Source: ABdhPJxk8XvHAtXsP1JXPHkA3kka3m4XzGODp2LcDn2So1QbFsSeyVkvDcGoQsIjbXIPo/pG+Keoqg== X-Received: by 2002:a17:906:56ca:: with SMTP id an10mr34126777ejc.498.1608196445214; Thu, 17 Dec 2020 01:14:05 -0800 (PST) Received: from avogadro.lan ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id e21sm22746778edv.96.2020.12.17.01.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Dec 2020 01:14:04 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH] vl: initialize displays _after_ exiting preconfiguration Date: Thu, 17 Dec 2020 10:14:03 +0100 Message-Id: <20201217091403.36195-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=paolo.bonzini@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Howard Spoelstra Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Due to the renumbering of text consoles when graphical consoles are created, init_displaystate must be called after all QemuConsoles are created, i.e. after devices are created. vl.c calls it from qemu_init_displays, while qmp_x_exit_preconfig is where devices are created. If qemu_init_displays is called before it, the VGA graphical console does not come up. Reported-by: Howard Spoelstra Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 0ed5c5ba93..7ddf405d76 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3529,10 +3529,10 @@ void qemu_init(int argc, char **argv, char **envp) exit(0); } - qemu_init_displays(); if (!preconfig_requested) { qmp_x_exit_preconfig(&error_fatal); } + qemu_init_displays(); accel_setup_post(current_machine); os_setup_post(); resume_mux_open(); -- 2.29.2