From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: virtio-fs@redhat.com, Laszlo Ersek <lersek@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH] virtiofsd: update FUSE_FORGET comment on "lo_inode.nlookup"
Date: Thu, 17 Dec 2020 15:01:04 +0000 [thread overview]
Message-ID: <20201217150104.GG4117@work-vm> (raw)
In-Reply-To: <20201208165610.GA20722@redhat.com>
* Vivek Goyal (vgoyal@redhat.com) wrote:
> On Tue, Dec 08, 2020 at 08:39:36AM +0100, Laszlo Ersek wrote:
> > Miklos confirms it's *only* the FUSE_FORGET request that the client can
> > use for decrementing "lo_inode.nlookup".
> >
> > Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > Cc: Miklos Szeredi <mszeredi@redhat.com>
> > Cc: Stefan Hajnoczi <stefanha@redhat.com>
> > Fixes: 1222f015558fc34cea02aa3a5a92de608c82cec8
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>
> Looks correct. unref_inode() calls in lo_rmdir() lo_rename() are dropping
> ->nlookup they have taken internally during the function execution.
>
> Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
Queued.
>
> Thanks
> Vivek
>
> > ---
> > tools/virtiofsd/passthrough_ll.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> > index 06543b20dcbb..d3be680e92c3 100644
> > --- a/tools/virtiofsd/passthrough_ll.c
> > +++ b/tools/virtiofsd/passthrough_ll.c
> > @@ -113,7 +113,7 @@ struct lo_inode {
> > * This counter keeps the inode alive during the FUSE session.
> > * Incremented when the FUSE inode number is sent in a reply
> > * (FUSE_LOOKUP, FUSE_READDIRPLUS, etc). Decremented when an inode is
> > - * released by requests like FUSE_FORGET, FUSE_RMDIR, FUSE_RENAME, etc.
> > + * released by a FUSE_FORGET request.
> > *
> > * Note that this value is untrusted because the client can manipulate
> > * it arbitrarily using FUSE_FORGET requests.
> > --
> > 2.19.1.3.g30247aa5d201
> >
> > _______________________________________________
> > Virtio-fs mailing list
> > Virtio-fs@redhat.com
> > https://www.redhat.com/mailman/listinfo/virtio-fs
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2020-12-17 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 7:39 [PATCH] virtiofsd: update FUSE_FORGET comment on "lo_inode.nlookup" Laszlo Ersek
2020-12-08 16:56 ` [Virtio-fs] " Vivek Goyal
2020-12-17 15:01 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217150104.GG4117@work-vm \
--to=dgilbert@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).