From: Maxim Levitsky <mlevitsk@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Alberto Garcia <berto@igalia.com>,
qemu-block@nongnu.org, Maxim Levitsky <mlevitsk@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [PATCH v6 1/3] crypto: luks: Fix tiny memory leak
Date: Thu, 17 Dec 2020 19:09:02 +0200 [thread overview]
Message-ID: <20201217170904.946013-2-mlevitsk@redhat.com> (raw)
In-Reply-To: <20201217170904.946013-1-mlevitsk@redhat.com>
When the underlying block device doesn't support the
bdrv_co_delete_file interface, an 'Error' object was leaked.
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block/crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/crypto.c b/block/crypto.c
index aef5a5721a..b3a5275132 100644
--- a/block/crypto.c
+++ b/block/crypto.c
@@ -735,6 +735,8 @@ fail:
*/
if ((r_del < 0) && (r_del != -ENOTSUP)) {
error_report_err(local_delete_err);
+ } else {
+ error_free(local_delete_err);
}
}
--
2.26.2
next prev parent reply other threads:[~2020-12-17 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 17:09 [PATCH v6 0/3] qcow2: don't leave partially initialized file on image creation Maxim Levitsky
2020-12-17 17:09 ` Maxim Levitsky [this message]
2020-12-17 17:09 ` [PATCH v6 2/3] block: add bdrv_co_delete_file_noerr Maxim Levitsky
2020-12-18 6:05 ` Vladimir Sementsov-Ogievskiy
2020-12-17 17:09 ` [PATCH v6 3/3] block: qcow2: remove the created file on initialization error Maxim Levitsky
2020-12-18 6:15 ` Vladimir Sementsov-Ogievskiy
2021-01-07 10:22 ` [PATCH v6 0/3] qcow2: don't leave partially initialized file on image creation Maxim Levitsky
2021-02-15 12:33 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217170904.946013-2-mlevitsk@redhat.com \
--to=mlevitsk@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).