From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Chen Qun" <kuhn.chenqun@huawei.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 13/14] hw/rtc/twl92230: Add missing 'break'
Date: Fri, 18 Dec 2020 09:27:03 +0100 [thread overview]
Message-ID: <20201218082704.2014294-3-thuth@redhat.com> (raw)
In-Reply-To: <20201218082704.2014294-1-thuth@redhat.com>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Add missing 'break' to fix:
hw/rtc/twl92230.c: In function ‘menelaus_write’:
hw/rtc/twl92230.c:713:5: error: label at end of compound statement
713 | default:
| ^~~~~~~
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20201211154605.511714-1-f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/rtc/twl92230.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/rtc/twl92230.c b/hw/rtc/twl92230.c
index a787bd247d..006d75e174 100644
--- a/hw/rtc/twl92230.c
+++ b/hw/rtc/twl92230.c
@@ -697,6 +697,7 @@ static void menelaus_write(void *opaque, uint8_t addr, uint8_t value)
#ifdef VERBOSE
printf("%s: unknown register %02x\n", __func__, addr);
#endif
+ break;
}
}
--
2.27.0
next prev parent reply other threads:[~2020-12-18 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 8:27 [PULL v2 00/14] Compile QEMU with -Wimplicit-fallthrough Thomas Huth
2020-12-18 8:27 ` [PULL 12/14] bsd-user: Silence warnings about missing fallthrough statement Thomas Huth
2020-12-18 8:27 ` Thomas Huth [this message]
2020-12-18 8:27 ` [PULL 14/14] configure: Compile with -Wimplicit-fallthrough=2 Thomas Huth
2020-12-31 14:48 ` [PULL v2 00/14] Compile QEMU with -Wimplicit-fallthrough Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218082704.2014294-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kuhn.chenqun@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).