From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C76C433E0 for ; Mon, 21 Dec 2020 13:46:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C40422BEA for ; Mon, 21 Dec 2020 13:46:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C40422BEA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krLW8-0006Wt-S2 for qemu-devel@archiver.kernel.org; Mon, 21 Dec 2020 08:46:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krLUp-0005HK-5m for qemu-devel@nongnu.org; Mon, 21 Dec 2020 08:45:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:34598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1krLUn-0003Pj-4L for qemu-devel@nongnu.org; Mon, 21 Dec 2020 08:45:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608558303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tz8yIxuH4gZ/YUJr0XMjtzsBFU0Ws7zsoZUtKCgGGhw=; b=KBghC+p6i80D0eJc2dwI3mBdudtq82MtOZARFsR2nfA5FowH9YKOy/E9MFsi40NFqscsuh DUGEW4faM6YEmvcxBmxRHIuJDIAtwv0myatFGSmfOZzQJr59NUK5/kSgrIRDShS4/MlVRP Bnhj5BNzEeC8FdN0ZQZpYB7+iwBXRHE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-FerefjMQM6up8efL6ftj2w-1; Mon, 21 Dec 2020 08:45:01 -0500 X-MC-Unique: FerefjMQM6up8efL6ftj2w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D9A3107ACE3; Mon, 21 Dec 2020 13:45:00 +0000 (UTC) Received: from gondolin (ovpn-113-49.ams2.redhat.com [10.36.113.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80F7B6F96F; Mon, 21 Dec 2020 13:44:52 +0000 (UTC) Date: Mon, 21 Dec 2020 14:44:50 +0100 From: Cornelia Huck To: Thomas Huth Subject: Re: [PATCH v3] tests/acceptance: Add a test with the Fedora 31 kernel and initrd Message-ID: <20201221144450.3e5fce49.cohuck@redhat.com> In-Reply-To: <20201221133254.4178703-1-thuth@redhat.com> References: <20201221133254.4178703-1-thuth@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Willian Rampazzo , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 21 Dec 2020 14:32:54 +0100 Thomas Huth wrote: > This initrd contains a virtio-net and a virtio-gpu kernel module, > so we can check that we can set a MAC address for the network device > and whether we can hot-plug and -unplug a virtio-crypto device. > But the most interesting part is maybe that we can also successfully > write some stuff into the emulated framebuffer of the virtio-gpu > device and make sure that we can read back that data from a screenshot. > > Reviewed-by: Wainer dos Santos Moschetta > Signed-off-by: Thomas Huth > --- > v3: > - Remove unused "import re" > - Use lscss to test for devnos > - Improve tmpfile handling (thanks Wainer!) > > tests/acceptance/machine_s390_ccw_virtio.py | 110 ++++++++++++++++++++ > 1 file changed, 110 insertions(+) (...) > + # Some tests to see whether the CLI options have been considered: > + self.log.info("Test whether QEMU CLI options have been considered") > + exec_command_and_wait_for_pattern(self, 'lspci', > + '0007:00:00.0 Class 0200: Device 1af4:1000') > + exec_command_and_wait_for_pattern(self, > + 'cat /sys/class/net/enP7p0s0/address', > + '02:ca:fe:fa:ce:12') > + exec_command_and_wait_for_pattern(self, 'lscss', '0.1.9876') > + self.wait_for_console_pattern('0.2.5432') This looks a bit odd... maybe do 'lscss -d 0.1.9876' and 'lscss -d 0.2.5432' and wait for the respective devnos to be printed? (I'm not entirely sure about the wait_for_console_pattern semantics here... can the 0.2.5432 line have been printed already before we start waiting, and would that be a problem? Might be better to play it safe.) (...)