From: Peter Lieven <pl@kamp.de>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, ct@flyingcircus.io, mreitz@redhat.com,
dillaman@redhat.com
Subject: [PATCH 7/7] block/rbd: change request alignment to 1 byte
Date: Sun, 27 Dec 2020 17:42:36 +0100 [thread overview]
Message-ID: <20201227164236.10143-8-pl@kamp.de> (raw)
In-Reply-To: <20201227164236.10143-1-pl@kamp.de>
since we implement byte interfaces and librbd supports aio on byte granularity we can lift
the 512 byte alignment.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/rbd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 27b4404adf..8673e8f553 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -223,8 +223,6 @@ done:
static void qemu_rbd_refresh_limits(BlockDriverState *bs, Error **errp)
{
BDRVRBDState *s = bs->opaque;
- /* XXX Does RBD support AIO on less than 512-byte alignment? */
- bs->bl.request_alignment = 512;
#ifdef LIBRBD_SUPPORTS_WRITE_ZEROES
bs->bl.pwrite_zeroes_alignment = s->object_size;
#endif
--
2.17.1
next prev parent reply other threads:[~2020-12-27 16:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 16:42 [PATCH 0/7] block/rbd: migrate to coroutines and add write zeroes support Peter Lieven
2020-12-27 16:42 ` [PATCH 1/7] block/rbd: bump librbd requirement to luminous release Peter Lieven
2020-12-27 16:42 ` [PATCH 2/7] block/rbd: store object_size in BDRVRBDState Peter Lieven
2020-12-27 16:42 ` [PATCH 3/7] block/rbd: use stored image_size in qemu_rbd_getlength Peter Lieven
2021-01-14 19:18 ` Jason Dillaman
2021-01-14 19:32 ` Peter Lieven
2020-12-27 16:42 ` [PATCH 4/7] block/rbd: add bdrv_{attach,detach}_aio_context Peter Lieven
2021-01-14 19:18 ` Jason Dillaman
2021-01-14 19:49 ` Peter Lieven
2020-12-27 16:42 ` [PATCH 5/7] block/rbd: migrate from aio to coroutines Peter Lieven
2021-01-14 19:19 ` Jason Dillaman
2021-01-14 19:39 ` Peter Lieven
2020-12-27 16:42 ` [PATCH 6/7] block/rbd: add write zeroes support Peter Lieven
2021-01-14 19:19 ` Jason Dillaman
2021-01-14 19:41 ` Peter Lieven
2021-01-15 15:09 ` Jason Dillaman
2020-12-27 16:42 ` Peter Lieven [this message]
2021-01-14 19:19 ` [PATCH 7/7] block/rbd: change request alignment to 1 byte Jason Dillaman
2021-01-14 19:59 ` Peter Lieven
2021-01-15 15:27 ` Jason Dillaman
2021-01-15 15:39 ` Peter Lieven
2021-01-18 22:33 ` Jason Dillaman
2021-01-19 9:36 ` Peter Lieven
2021-01-19 14:20 ` Jason Dillaman
-- strict thread matches above, loose matches on Subject: below --
2021-01-20 23:01 Peter Lieven
2021-01-21 19:42 ` Jason Dillaman
2021-01-21 20:29 ` Peter Lieven
2021-01-21 20:55 ` Jason Dillaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201227164236.10143-8-pl@kamp.de \
--to=pl@kamp.de \
--cc=ct@flyingcircus.io \
--cc=dillaman@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).