From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: Daniel Henrique Barboza <danielhb@linux.ibm.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 5/6] spapr: Add drc_ prefix to the DRC realize and unrealize functions
Date: Mon, 28 Dec 2020 18:31:03 +1100 [thread overview]
Message-ID: <20201228073103.GK6952@yekko.fritz.box> (raw)
In-Reply-To: <20201218103400.689660-6-groug@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 2394 bytes --]
On Fri, Dec 18, 2020 at 11:33:59AM +0100, Greg Kurz wrote:
> Use a less generic name for an easier experience with tools such as
> cscope or grep.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Applied to ppc-for-6.0, thanks.
> ---
> hw/ppc/spapr_drc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index a4d2608017c5..8571d5bafe4e 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -503,7 +503,7 @@ static const VMStateDescription vmstate_spapr_drc = {
> }
> };
>
> -static void realize(DeviceState *d, Error **errp)
> +static void drc_realize(DeviceState *d, Error **errp)
> {
> SpaprDrc *drc = SPAPR_DR_CONNECTOR(d);
> Object *root_container;
> @@ -530,7 +530,7 @@ static void realize(DeviceState *d, Error **errp)
> trace_spapr_drc_realize_complete(spapr_drc_index(drc));
> }
>
> -static void unrealize(DeviceState *d)
> +static void drc_unrealize(DeviceState *d)
> {
> SpaprDrc *drc = SPAPR_DR_CONNECTOR(d);
> Object *root_container;
> @@ -579,8 +579,8 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data)
> {
> DeviceClass *dk = DEVICE_CLASS(k);
>
> - dk->realize = realize;
> - dk->unrealize = unrealize;
> + dk->realize = drc_realize;
> + dk->unrealize = drc_unrealize;
> /*
> * Reason: DR connector needs to be wired to either the machine or to a
> * PHB in spapr_dr_connector_new().
> @@ -628,7 +628,7 @@ static void realize_physical(DeviceState *d, Error **errp)
> SpaprDrcPhysical *drcp = SPAPR_DRC_PHYSICAL(d);
> Error *local_err = NULL;
>
> - realize(d, &local_err);
> + drc_realize(d, &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
> return;
> @@ -644,7 +644,7 @@ static void unrealize_physical(DeviceState *d)
> {
> SpaprDrcPhysical *drcp = SPAPR_DRC_PHYSICAL(d);
>
> - unrealize(d);
> + drc_unrealize(d);
> vmstate_unregister(VMSTATE_IF(drcp), &vmstate_spapr_drc_physical, drcp);
> qemu_unregister_reset(drc_physical_reset, drcp);
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-28 7:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 10:33 [PATCH 0/6] spapr: Fix visibility and traversal of DR connectors Greg Kurz
2020-12-18 10:33 ` [PATCH 1/6] spapr: Call spapr_drc_reset() for all DRCs at CAS Greg Kurz
2020-12-21 18:24 ` Daniel Henrique Barboza
2020-12-28 7:20 ` David Gibson
2020-12-18 10:33 ` [PATCH 2/6] spapr: Fix reset of transient DR connectors Greg Kurz
2020-12-21 20:34 ` Daniel Henrique Barboza
2020-12-28 7:24 ` David Gibson
2020-12-18 10:33 ` [PATCH 3/6] spapr: Introduce spapr_drc_reset_all() Greg Kurz
2020-12-21 20:35 ` Daniel Henrique Barboza
2020-12-28 7:26 ` David Gibson
2020-12-18 10:33 ` [PATCH 4/6] spapr: Use spapr_drc_reset_all() at machine reset Greg Kurz
2020-12-21 20:36 ` Daniel Henrique Barboza
2020-12-28 7:29 ` David Gibson
2020-12-18 10:33 ` [PATCH 5/6] spapr: Add drc_ prefix to the DRC realize and unrealize functions Greg Kurz
2020-12-21 20:37 ` Daniel Henrique Barboza
2020-12-28 7:31 ` David Gibson [this message]
2020-12-18 10:34 ` [PATCH 6/6] spapr: Model DR connectors as simple objects Greg Kurz
2020-12-21 20:45 ` Daniel Henrique Barboza
2020-12-28 8:28 ` David Gibson
2021-01-06 18:15 ` Greg Kurz
2021-02-08 6:30 ` David Gibson
2020-12-22 10:14 ` [PATCH 0/6] spapr: Fix visibility and traversal of DR connectors Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228073103.GK6952@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=danielhb@linux.ibm.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).