Re: [PATCH] meson: fix ncurses detection on macOS

[Samuel Thibault <samuel.thibault@gnu.org>]

Philippe Mathieu-Daudé, le lun. 28 déc. 2020 18:20:13 +0100, a ecrit:
> On 12/28/20 4:16 PM, Chris Hofstaedtler wrote:
> > Without this, meson fails with "curses package not usable"
> > when using ncurses 6.2. Apparently the wide functions
> > (addwstr, etc) are hidden behind the extra define, and
> > meson does not define it at that detection stage.
> 
> Seems reasonable, but still Cc'ing more developers.

That looks sensible indeed.


> > Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
> > ---
> >  meson.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index 9c152a85bd..7b9d92c14a 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -510,7 +510,7 @@ if have_system and not get_option('curses').disabled()
> >    endforeach
> >    msg = get_option('curses').enabled() ? 'curses library not found' : ''
> >    if curses.found()
> > -    if cc.links(curses_test, dependencies: [curses])
> > +    if cc.links(curses_test, args: '-DNCURSES_WIDECHAR', dependencies: [curses])
> >        curses = declare_dependency(compile_args: '-DNCURSES_WIDECHAR', dependencies: [curses])
> >      else
> >        msg = 'curses package not usable'