qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Greg Kurz <groug@kaod.org>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 0/4] hw/ppc: Convert UIC device to QOM
Date: Fri,  8 Jan 2021 17:12:08 +0000	[thread overview]
Message-ID: <20210108171212.16500-1-peter.maydell@linaro.org> (raw)

This patchseries converts the PPC UIC "Universal Interrupt
Controller" to a QOM device.  My main reason for doing it is that
this fixes a couple of long-standing trivial Coverity issues -- the
current ppcuic_init() function allocates an array of qemu_irqs which
the callers then leak.  (The leak is trivial because it happens once
when QEMU starts.)

The first half of v1 is in master now, so this is just a
respin of the last four patches.

Changes v1->v2:
 * fixed the bug in the sam460ex conversion handling of CINT
   (tested that this now boots AROS OK to a desktop)
 * other minor code style tweaks to patch 1 as per review

thanks
-- PMM

Peter Maydell (4):
  hw/ppc/sam460ex: Drop use of ppcuic_init()
  hw/ppc: Delete unused ppc405cr_init() code
  hw/ppc/ppc405_uc: Drop use of ppcuic_init()
  hw/ppc: Remove unused ppcuic_init()

 hw/ppc/ppc405.h           |   8 +-
 include/hw/intc/ppc-uic.h |   7 +
 include/hw/ppc/ppc4xx.h   |   9 -
 hw/ppc/ppc405_boards.c    |   8 +-
 hw/ppc/ppc405_uc.c        | 415 ++++----------------------------------
 hw/ppc/ppc4xx_devs.c      |  38 ----
 hw/ppc/sam460ex.c         |  69 +++++--
 7 files changed, 107 insertions(+), 447 deletions(-)

-- 
2.20.1



             reply	other threads:[~2021-01-08 17:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 17:12 Peter Maydell [this message]
2021-01-08 17:12 ` [PATCH v2 1/4] hw/ppc/sam460ex: Drop use of ppcuic_init() Peter Maydell
2021-01-08 22:16   ` BALATON Zoltan
2021-01-08 17:12 ` [PATCH v2 2/4] hw/ppc: Delete unused ppc405cr_init() code Peter Maydell
2021-01-08 17:12 ` [PATCH v2 3/4] hw/ppc/ppc405_uc: Drop use of ppcuic_init() Peter Maydell
2021-01-08 17:12 ` [PATCH v2 4/4] hw/ppc: Remove unused ppcuic_init() Peter Maydell
2021-01-11  9:23 ` [PATCH v2 0/4] hw/ppc: Convert UIC device to QOM David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108171212.16500-1-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).