From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3111DC433DB for ; Mon, 11 Jan 2021 16:06:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A562E21D7F for ; Mon, 11 Jan 2021 16:06:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A562E21D7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyziX-0005ts-5v for qemu-devel@archiver.kernel.org; Mon, 11 Jan 2021 11:06:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyzhG-0004re-Dc for qemu-devel@nongnu.org; Mon, 11 Jan 2021 11:05:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kyzhD-0002F9-FZ for qemu-devel@nongnu.org; Mon, 11 Jan 2021 11:05:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610381130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IB3QPMuByTTOVICXJdlHGq/IVT6ouhTLlc4OS/8cjYE=; b=EtyalI/kTKxnqv0on/H8LjSOpDQZ6VPa9AebPatruXHTY0UhnTRGee3jf9vLJm5x/4rdKB mlTxCyfdmrhYfhgnCeXCgVbvh9kRB+2kfKUpnaeHFwA+vgYw4ibHFCF0TuCgjzhvd4g2rp UN1kwaI25gnBU0MHMq3d04EyWul+lk4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-329-2pgBWM7KOYyysIor8y-5rQ-1; Mon, 11 Jan 2021 11:05:28 -0500 X-MC-Unique: 2pgBWM7KOYyysIor8y-5rQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD0A08030A8; Mon, 11 Jan 2021 16:05:27 +0000 (UTC) Received: from gondolin (ovpn-112-169.ams2.redhat.com [10.36.112.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id D64085D9DB; Mon, 11 Jan 2021 16:05:13 +0000 (UTC) Date: Mon, 11 Jan 2021 17:05:10 +0100 From: Cornelia Huck To: "Michael S. Tsirkin" Subject: Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2 Message-ID: <20210111170510.75eaa499.cohuck@redhat.com> In-Reply-To: <20210111101313-mutt-send-email-mst@kernel.org> References: <20210104202057.48048-1-farman@linux.ibm.com> <20210104202057.48048-3-farman@linux.ibm.com> <20210111135404.52f18200.cohuck@redhat.com> <20210111075950-mutt-send-email-mst@kernel.org> <20210111144322.32812f16.cohuck@redhat.com> <20210111100002-mutt-send-email-mst@kernel.org> <5c93b577-7db7-681a-307a-8283bb0ccbe8@linux.ibm.com> <20210111101313-mutt-send-email-mst@kernel.org> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-s390x@nongnu.org, Eric Farman , qemu-devel@nongnu.org, Alex Williamson , stefanha@redhat.com, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 11 Jan 2021 10:18:28 -0500 "Michael S. Tsirkin" wrote: > On Mon, Jan 11, 2021 at 10:11:23AM -0500, Eric Farman wrote: > > > > > > On 1/11/21 10:00 AM, Michael S. Tsirkin wrote: > > > On Mon, Jan 11, 2021 at 02:43:22PM +0100, Cornelia Huck wrote: > > > > On Mon, 11 Jan 2021 08:00:45 -0500 > > > > "Michael S. Tsirkin" wrote: > > > > > > > > > On Mon, Jan 11, 2021 at 01:54:04PM +0100, Cornelia Huck wrote: > > > > > > On Mon, 4 Jan 2021 21:20:56 +0100 > > > > > > Eric Farman wrote: > > > > > > > Signed-off-by: Eric Farman > > > > > > > --- > > > > > > > .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h | 14 +- > > > > > > > .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +- > > > > > > > include/standard-headers/drm/drm_fourcc.h | 175 +++++++++++++++++- > > > > > > > include/standard-headers/linux/const.h | 36 ++++ > > > > > > > include/standard-headers/linux/ethtool.h | 2 +- > > > > > > > include/standard-headers/linux/fuse.h | 30 ++- > > > > > > > include/standard-headers/linux/kernel.h | 9 +- > > > > > > > include/standard-headers/linux/pci_regs.h | 16 ++ > > > > > > > include/standard-headers/linux/vhost_types.h | 9 + > > > > > > > include/standard-headers/linux/virtio_gpu.h | 82 ++++++++ > > > > > > > include/standard-headers/linux/virtio_ids.h | 44 +++-- > > > > > > > linux-headers/asm-arm64/kvm.h | 3 - > > > > > > > linux-headers/asm-generic/unistd.h | 6 +- > > > > > > > linux-headers/asm-mips/unistd_n32.h | 1 + > > > > > > > linux-headers/asm-mips/unistd_n64.h | 1 + > > > > > > > linux-headers/asm-mips/unistd_o32.h | 1 + > > > > > > > linux-headers/asm-powerpc/unistd_32.h | 1 + > > > > > > > linux-headers/asm-powerpc/unistd_64.h | 1 + > > > > > > > linux-headers/asm-s390/unistd_32.h | 1 + > > > > > > > linux-headers/asm-s390/unistd_64.h | 1 + > > > > > > > linux-headers/asm-x86/kvm.h | 1 + > > > > > > > linux-headers/asm-x86/unistd_32.h | 1 + > > > > > > > linux-headers/asm-x86/unistd_64.h | 1 + > > > > > > > linux-headers/asm-x86/unistd_x32.h | 1 + > > > > > > > linux-headers/linux/kvm.h | 56 +++++- > > > > > > > linux-headers/linux/userfaultfd.h | 9 + > > > > > > > linux-headers/linux/vfio.h | 1 + > > > > > > > linux-headers/linux/vhost.h | 4 + > > > > > > > 28 files changed, 461 insertions(+), 48 deletions(-) > > > > > > > create mode 100644 include/standard-headers/linux/const.h > > > > > > > > > > > > > > diff --git a/include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h b/include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h > > > > > > > index 7b4062a1a1..acd4c8346d 100644 > > > > > > > --- a/include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h > > > > > > > +++ b/include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h > > > > > > > @@ -68,7 +68,7 @@ static inline int pvrdma_idx_valid(uint32_t idx, uint32_t max_elems) > > > > > > > static inline int32_t pvrdma_idx(int *var, uint32_t max_elems) > > > > > > > { > > > > > > > - const unsigned int idx = qatomic_read(var); > > > > > > > + const unsigned int idx = atomic_read(var); > > > > > > > > > > > > Hm, what was the state of these qatomic* instances in this header? Is > > > > > > it ok to rename them, or do we need to do some munging in the import > > > > > > script? > > > > > > > > > > > > (Sorry, it's been a while.) > > > > > > > > > > > > > > > Yea looks like it was done manually last time: > > > > > > > > > > commit d73415a315471ac0b127ed3fad45c8ec5d711de1 > > > > > Author: Stefan Hajnoczi > > > > > Date: Wed Sep 23 11:56:46 2020 +0100 > > > > > > > > > > qemu/atomic.h: rename atomic_ to qatomic_ > > > > > > > > It seems that this hunk was dropped manually last time: > > > > > > > > commit 53ba2eee52bff5a746e96835539a1079f6bcadd1 > > > > Author: Matthew Rosato > > > > Date: Mon Oct 26 11:34:30 2020 -0400 > > > > > > > > linux-headers: update against 5.10-rc1 > > > > commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec > > > > Signed-off-by: Matthew Rosato > > > > [aw: drop pvrdma_ring.h changes to avoid revert of d73415a31547 ("qemu/atomic.h: rename atomic_ to qatomic_")] > > > > Signed-off-by: Alex Williamson > > > > > > > > I can do that as well, but I'm not sure that this is the best way > > > > forward. > > > > > > Probably as easy as the following: > > > > > > Signed-off-by: Michael S. Tsirkin > > > > > > > > > > > > diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh > > > index 9efbaf2f84..c1b4f468d3 100755 > > > --- a/scripts/update-linux-headers.sh > > > +++ b/scripts/update-linux-headers.sh > > > @@ -70,6 +70,8 @@ cp_portable() { > > > -e 's/__kernel_long_t/long/' \ > > > -e 's/__kernel_ulong_t/unsigned long/' \ > > > -e 's/struct ethhdr/struct eth_header/' \ > > > + -e 's/atomic_read/qatomic_read/' \ > > > + -e 's/atomic_set/qatomic_set/' \ > > > -e '/\#define _LINUX_ETHTOOL_H/a \\n\#include "net/eth.h"' \ > > > "$f" > "$to/$header"; > > > } > > > > > > > Possibly, but Paolo mentioned the problem in this space some months ago: > > > > """ > > > It looks like the changes in this file are going to get reverted the > > > next time someone does a linux header sync. > > > > Source code should not be at all imported from Linux. The hacks that > > accomodate pvrdma in update-linux-headers.sh (like s/atomic_t/u32/) > > really have no place there; the files in > > include/standard-headers/drivers/infiniband/hw/vmw_pvrdma should all be > > moved in hw/. I'm not sure about the other headers, but the contents in pvrdma_ring.h really do not look like an api to me. > > > > Paolo > > """ > > > > https://lore.kernel.org/qemu-devel/45ba3626-0e06-96c7-5ed8-ea561ae20f15@redhat.com/ > > > Oh right. I think they really should be moved to UAPI in Linux. > Any takers? Maybe it's just this basically: > > Signed-off-by: Michael S. Tsirkin > > > diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma.h b/drivers/infiniband/hw/vmw_pvrdma/pvrdma.h > index c142f5e7f25f..4a4834de9677 100644 > --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma.h > +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma.h > @@ -57,9 +57,9 @@ > #include > #include > > -#include "pvrdma_ring.h" > +#include > #include "pvrdma_dev_api.h" > -#include "pvrdma_verbs.h" > +#include > > /* NOT the same as BIT_MASK(). */ > #define PVRDMA_MASK(n) ((n << 1) - 1) > diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h > index 86a6c054ea26..d9a8ee79b9c0 100644 > --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h > +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h > @@ -48,7 +48,7 @@ > > #include > > -#include "pvrdma_verbs.h" > +#include > > /* > * PVRDMA version macros. Some new features require updates to PVRDMA_VERSION. > diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h b/include/uapi/linux/pvrdma_ring.h > similarity index 100% > rename from drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h > rename to include/uapi/linux/pvrdma_ring.h > diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h b/include/uapi/linux/pvrdma_verbs.h > similarity index 100% > rename from drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h > rename to include/uapi/linux/pvrdma_verbs.h How api-like are these? The verbs look like something that might be, but the rest?