From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB7DEC433E0 for ; Mon, 11 Jan 2021 19:47:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21FE422BEF for ; Mon, 11 Jan 2021 19:47:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21FE422BEF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz39z-0006LV-1p for qemu-devel@archiver.kernel.org; Mon, 11 Jan 2021 14:47:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz2ne-0000gL-E9 for qemu-devel@nongnu.org; Mon, 11 Jan 2021 14:24:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kz2nb-000194-1I for qemu-devel@nongnu.org; Mon, 11 Jan 2021 14:24:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610393042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r2mxFIi3v4zgPeSdBudHxaoU/iLZxzphoG7C1sMttQQ=; b=dlYY1jQI37mYCifKURCNB3yI4Xjm9tPYtEcSgprgx686RVWq/ZSmNJHmyvTXgoZEW3sOOO 0BZNy1yfC3Xonxb7J0QDwi8nAt4tt8Np0GSUgmJbMZ5iGTR6Rh6hbS9SjcfQHRgKjAjKoy Dwack7Txo8HlDz3LWZ29lUE4FDbRt1I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-N8Z_Ud21OaqTBB9j-nxZVQ-1; Mon, 11 Jan 2021 14:24:01 -0500 X-MC-Unique: N8Z_Ud21OaqTBB9j-nxZVQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17D02AFA83; Mon, 11 Jan 2021 19:23:59 +0000 (UTC) Received: from localhost (unknown [10.40.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 48F6B60854; Mon, 11 Jan 2021 19:23:48 +0000 (UTC) Date: Mon, 11 Jan 2021 20:23:47 +0100 From: Igor Mammedov To: Marian Posteuca Subject: Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed Message-ID: <20210111202347.41b65fd5@redhat.com> In-Reply-To: <87bldvldsl.fsf@mutex.one> References: <20201230221302.26800-1-posteuca@mutex.one> <20210106182430.6bf1823a@redhat.com> <87bldvldsl.fsf@mutex.one> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sergio Lopez , Eduardo Habkost , Ben Warren , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Dongjiu Geng , Shannon Zhao , Xiang Zheng , qemu-arm@nongnu.org, Paolo Bonzini , Xiao Guangrong Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 11 Jan 2021 16:59:54 +0200 Marian Posteuca wrote: > Igor Mammedov writes: > > > overall looks good. > > Please add a test case for it, see > > tests/qtest/bios-tables-test.c for description how to do it > > an/or at > > "[PATCH v3 08/12] tests/acpi: allow updates for expected data files" > > and follow up patches on the list. > When you say add a test case, do you mean only updating the binary > files in tests/data/acpi/{microvm,pc,q35,virt} according to the steps > at the start of the file bios-tables-test.c? Or do you also mean an actual > test case to be added in bios-tables-test.c? an new test in bios-tables-test.c, which will test that new option works as expected. > Also the step 6 described in bios-tables-test.c mentions that the diff of > the ACPI table must be added to the commit log, but my change touches > all the tables for all architectures so that would mean that I would > have to create a huge commit log. How should I approach this? I don't think that large commit message is problem, it helps reviewer to see expected changes (if|before one actually tests)