From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2700EC433E0 for ; Tue, 12 Jan 2021 11:49:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA29323104 for ; Tue, 12 Jan 2021 11:49:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA29323104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzIAy-0002Sn-IE for qemu-devel@archiver.kernel.org; Tue, 12 Jan 2021 06:49:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzHsD-0004iy-En for qemu-devel@nongnu.org; Tue, 12 Jan 2021 06:30:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kzHsB-0001Sy-9i for qemu-devel@nongnu.org; Tue, 12 Jan 2021 06:30:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610451001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dRiaAu9hETYu/BXG8y6YWk/SYgh2bgnB6lVdCYZbJwU=; b=VzsycT9ig00Vh1e+Ax2bZpZAe0PtW2P1RCDsQU6/lbtJPTSFaueKM0vaDRCWRuE5XDRT4X hQMgxvDzqei2dD16LbasqmtLVx1m6J3Nwuz+kMqxq3d/jxl8mu9sORFDH8vybtqqBPJcYd R2zv+IpQzNSBjfx2ASfmWWwM6MU38ME= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-hRAH5Wu7Nru8Kz6vcAy1qg-1; Tue, 12 Jan 2021 06:29:59 -0500 X-MC-Unique: hRAH5Wu7Nru8Kz6vcAy1qg-1 Received: by mail-wr1-f72.google.com with SMTP id g16so1018935wrv.1 for ; Tue, 12 Jan 2021 03:29:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dRiaAu9hETYu/BXG8y6YWk/SYgh2bgnB6lVdCYZbJwU=; b=DupqVRwpMZ1KBZOIHya2sLS4Wj9gPpGoYSAX9yGkU/IkhPj62DnHILJ8+qrUjQeg1J 7V91Bi569/KVt9P3YILpgcX3f/7iPtCJ6jJiQ9+sNzsEE9yoxqat09ZpVniExenjYzVy VKsSW55oto4XrZFh94r/WdKMbdLNFkdWYA4ybvVuPRjEt6iwhV8NI2yrs/iZCRmZLlMQ 0nQX/yGjZjtHs6RDkOjv1N3OW0PRJaHlqHseyAr9OVF2c1s1CUZ1rcUQJoBhNy5L21Nq v05xJl4bZZ4EhW25Zyfvg3XpgWG365cs9dxZLT96gJXXPtZkYppPVP9yqu/ricDDzFJq CUpw== X-Gm-Message-State: AOAM5338AR/n9gIXNrI0jSwU1fM0sMABMP1vfkN0vzowWGFIo74ipV4q dlLVYT/OF5pGujVDWkNAujAHm91FX7G7HMEuGuLmB39QAHFKNs0XQw6xDqugdiZ4j0HSfUC9Osz 21pIDX1l7DlubWF+6yC0O8f7vLx71S5NKL8NVxeK9EReG92bijTUZt31aWG2meRoR X-Received: by 2002:adf:dc84:: with SMTP id r4mr3739687wrj.232.1610450998270; Tue, 12 Jan 2021 03:29:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxOCkOEWLUrR2VTOfh7upb+ZmDxb4KFoAyvMlLsnIrxZeGnKt4CZvlhL66lzNjHfSzeOppwvQ== X-Received: by 2002:adf:dc84:: with SMTP id r4mr3739671wrj.232.1610450998092; Tue, 12 Jan 2021 03:29:58 -0800 (PST) Received: from localhost.localdomain (190.red-83-57-173.dynamicip.rima-tde.net. [83.57.173.190]) by smtp.gmail.com with ESMTPSA id j59sm5067392wrj.13.2021.01.12.03.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 03:29:57 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR) Date: Tue, 12 Jan 2021 12:29:55 +0100 Message-Id: <20210112112955.1849212-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , John Snow , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Replace fprintf() calls by qemu_log_mask(LOG_GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/ahci.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 4b675b9cfd8..6d50482b8d1 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -465,8 +465,9 @@ static void ahci_mem_write(void *opaque, hwaddr addr, /* Only aligned reads are allowed on AHCI */ if (addr & 3) { - fprintf(stderr, "ahci: Mis-aligned write to addr 0x" - TARGET_FMT_plx "\n", addr); + qemu_log_mask(LOG_GUEST_ERROR, + "ahci: Mis-aligned write to addr 0x%03" HWADDR_PRIX "\n", + addr); return; } @@ -1111,7 +1112,8 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis, g_assert(is_ncq(ncq_fis->command)); if (ncq_tfs->used) { /* error - already in use */ - fprintf(stderr, "%s: tag %d already used\n", __func__, tag); + qemu_log_mask(LOG_GUEST_ERROR, "%s: tag %d already used\n", + __func__, tag); return; } -- 2.26.2