From: Bin Meng <bmeng.cn@gmail.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Bin Meng <bin.meng@windriver.com>
Subject: [PATCH v5 4/6] hw/ssi: imx_spi: Round up the burst length to be multiple of 8
Date: Tue, 12 Jan 2021 22:55:24 +0800 [thread overview]
Message-ID: <20210112145526.31095-5-bmeng.cn@gmail.com> (raw)
In-Reply-To: <20210112145526.31095-1-bmeng.cn@gmail.com>
From: Bin Meng <bin.meng@windriver.com>
Current implementation of the imx spi controller expects the burst
length to be multiple of 8, which is the most common use case.
In case the burst length is not what we expect, log it to give user
a chance to notice it, and round it up to be multiple of 8.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
Changes in v5:
- round up the burst length to be multiple of 8
Changes in v4:
- s/normal/common/ in the commit message
- log the burst length value in the log message
Changes in v3:
- new patch: log unimplemented burst length
hw/ssi/imx_spi.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c
index 880939f595..b7456de065 100644
--- a/hw/ssi/imx_spi.c
+++ b/hw/ssi/imx_spi.c
@@ -128,7 +128,20 @@ static uint8_t imx_spi_selected_channel(IMXSPIState *s)
static uint32_t imx_spi_burst_length(IMXSPIState *s)
{
- return EXTRACT(s->regs[ECSPI_CONREG], ECSPI_CONREG_BURST_LENGTH) + 1;
+ uint32_t burst;
+
+ burst = EXTRACT(s->regs[ECSPI_CONREG], ECSPI_CONREG_BURST_LENGTH) + 1;
+ if (burst % 8) {
+ qemu_log_mask(LOG_UNIMP,
+ "[%s]%s: burst length (%d) not multiple of 8!\n",
+ TYPE_IMX_SPI, __func__, burst);
+ burst = ROUND_UP(burst, 8);
+ qemu_log_mask(LOG_UNIMP,
+ "[%s]%s: burst length rounded up to %d; this may not work.\n",
+ TYPE_IMX_SPI, __func__, burst);
+ }
+
+ return burst;
}
static bool imx_spi_is_enabled(IMXSPIState *s)
--
2.25.1
next prev parent reply other threads:[~2021-01-12 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 14:55 [PATCH v5 0/6] hw/ssi: imx_spi: Fix various bugs in the imx_spi model Bin Meng
2021-01-12 14:55 ` [PATCH v5 1/6] hw/ssi: imx_spi: Use a macro for number of chip selects supported Bin Meng
2021-01-12 14:55 ` [PATCH v5 2/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset() Bin Meng
2021-01-12 14:55 ` [PATCH v5 3/6] hw/ssi: imx_spi: Disable chip selects when controller is disabled Bin Meng
2021-01-12 14:55 ` Bin Meng [this message]
2021-01-12 14:55 ` [PATCH v5 5/6] hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic Bin Meng
2021-01-12 14:55 ` [PATCH v5 6/6] hw/ssi: imx_spi: Correct tx and rx fifo endianness Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112145526.31095-5-bmeng.cn@gmail.com \
--to=bmeng.cn@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=f4bug@amsat.org \
--cc=jcd@tribudubois.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).