qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, lukasstraub2@web.de,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [PULL 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test
Date: Wed, 13 Jan 2021 10:31:01 +0100	[thread overview]
Message-ID: <20210113093101.550964-8-armbru@redhat.com> (raw)
In-Reply-To: <20210113093101.550964-1-armbru@redhat.com>

From: Lukas Straub <lukasstraub2@web.de>

A connecting chardev object has an additional reference by the connecting
thread, so if the chardev is still connecting by the end of the test,
then the chardev object won't be freed. This in turn means that the yank
instance won't be unregistered and when running the next test-case
yank_register_instance will abort, because the yank instance is
already/still registered.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <1445e97a5800e3f2ba024ad52b500a0315701632.1609167865.git.lukasstraub2@web.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 tests/test-char.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/test-char.c b/tests/test-char.c
index 06102977b6..469d25989c 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -937,6 +937,7 @@ static void char_socket_client_dupid_test(gconstpointer opaque)
     g_assert_nonnull(opts);
     chr1 = qemu_chr_new_from_opts(opts, NULL, &error_abort);
     g_assert_nonnull(chr1);
+    qemu_chr_wait_connected(chr1, &error_abort);
 
     chr2 = qemu_chr_new_from_opts(opts, NULL, &local_err);
     g_assert_null(chr2);
-- 
2.26.2



  parent reply	other threads:[~2021-01-13  9:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13  9:30 [PULL 0/7] Yank patches patches for 2021-01-13 Markus Armbruster
2021-01-13  9:30 ` [PULL 1/7] Introduce yank feature Markus Armbruster
2021-01-13  9:30 ` [PULL 2/7] block/nbd.c: Add " Markus Armbruster
2021-01-13  9:30 ` [PULL 3/7] chardev/char-socket.c: " Markus Armbruster
2021-01-13  9:30 ` [PULL 4/7] migration: " Markus Armbruster
2021-01-13  9:30 ` [PULL 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe Markus Armbruster
2021-01-13  9:31 ` [PULL 6/7] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown Markus Armbruster
2021-01-13  9:31 ` Markus Armbruster [this message]
2021-01-13 15:53 ` [PULL 0/7] Yank patches patches for 2021-01-13 Peter Maydell
2021-01-13 16:25   ` Markus Armbruster
2021-01-13 17:26     ` Lukas Straub
2021-01-14 11:02   ` Alex Bennée
2021-01-14 12:40     ` Markus Armbruster
2021-01-14 12:44       ` Lukas Straub
2021-01-14 13:19     ` [PATCH] Fix build with new yank feature by adding stubs Lukas Straub
2021-01-14 13:46       ` Alex Bennée
2021-01-14 14:04       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113093101.550964-8-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=lukasstraub2@web.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).