Re: [PATCH v2] vhost-user-fs: add the "bootindex" property

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]

On Tue, Jan 12, 2021 at 02:16:03PM +0100, Laszlo Ersek wrote:
> virtio-fs qualifies as a bootable device minimally under OVMF, but
> currently the necessary "bootindex" property is missing. Add the property.
> 
> Expose the property only in the PCI device, for now. There is no boot
> support for virtiofs on s390x (ccw) for the time being [1] [2], so leave
> the CCW device unchanged. Add the property to the base device still,
> because adding the alias to the CCW device later will be easier this way
> [3].
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg01745.html
> [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg01870.html
> [3] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg01751.html
> 
> Example OpenFirmware device path for the "vhost-user-fs-pci" device in the
> "bootorder" fw_cfg file:
> 
>   /pci@i0cf8/pci-bridge@1,6/pci1af4,105a@0/filesystem@0
> 
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Ján Tomko <jtomko@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: virtio-fs@redhat.com
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> 
> Notes:
>     v2:
>     - drop "hw/s390x/vhost-user-fs-ccw.c" hunk [Christian, Cornelia]
>     
>     - document the same in the commit message
>     
>     - remove fw_cfg kernel boot reference from the commit message (somewhat
>       similar use case, but a comparison or even a hint doesn't necessarily
>       belong in the commit message)
>     
>     - pick up Dave's ACK
> 
>  include/hw/virtio/vhost-user-fs.h |  1 +
>  hw/virtio/vhost-user-fs-pci.c     |  2 ++
>  hw/virtio/vhost-user-fs.c         | 10 ++++++++++
>  3 files changed, 13 insertions(+)

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]