From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH 0/7] iotests/129: Fix it
Date: Wed, 13 Jan 2021 16:43:35 +0100 [thread overview]
Message-ID: <20210113154335.GC5928@merkur.fritz.box> (raw)
In-Reply-To: <72a1b15b-88c8-34f5-9e81-3aadcde333ca@redhat.com>
Am 13.01.2021 um 16:26 hat Max Reitz geschrieben:
> On 13.01.21 15:38, Kevin Wolf wrote:
> > Am 13.01.2021 um 15:06 hat Max Reitz geschrieben:
> > > - pylint and mypy complain.
> > > (Running mypy with the options given in 297.)
> > > [Patch 4 removes one pylint complaint; patch 7 the rest.]
> >
> > Should we add it to 297 then to make sure we won't regress?
>
> Sounds like a good precedent to set indeed.
>
> > At some point, I guess we'll want to cover all Python tests, but I
> > assume it was too much to change in the same series as for the
> > iotests.py cleanup.
> Originally, I hadn’t intended to write patch 7 at all; I just wanted to see
> what pylint/mypy said to my changes in this series, but then they made me
> aware of pre-existing litter. I thought adding patch 7 would be the right
> thing to do, so I did.
>
> (That’s to say so far I had no intentions of cleaning up all Python tests.
> It’s just coincidence that I did so for 129.)
Indeed, and I wasn't trying to imply that you should, but just making a
guess why we cover iotests.py and nothing else so far.
Cleaning up 129 is a nice side effect of this series. If more such side
effects accumulate and the rest becomes small enough, I might eventually
just convert the rest. Or I might not, who knows.
Kevin
prev parent reply other threads:[~2021-01-13 15:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 14:06 [PATCH 0/7] iotests/129: Fix it Max Reitz
2021-01-13 14:06 ` [PATCH 1/7] iotests: Move try_remove to iotests.py Max Reitz
2021-01-13 14:25 ` Eric Blake
2021-01-13 14:06 ` [PATCH 2/7] iotests/129: Remove test images in tearDown() Max Reitz
2021-01-13 14:34 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:43 ` Eric Blake
2021-01-13 14:06 ` [PATCH 3/7] iotests/129: Do not check @busy Max Reitz
2021-01-13 14:48 ` Eric Blake
2021-01-13 15:01 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 4/7] iotests/129: Use throttle node Max Reitz
2021-01-13 14:10 ` Max Reitz
2021-01-13 14:53 ` Eric Blake
2021-01-13 15:07 ` Vladimir Sementsov-Ogievskiy
2021-01-13 15:15 ` Max Reitz
2021-01-13 16:46 ` Vladimir Sementsov-Ogievskiy
2021-01-13 17:02 ` Max Reitz
2021-01-13 17:05 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 5/7] iotests/129: Actually test a commit job Max Reitz
2021-01-13 15:58 ` Eric Blake
2021-01-13 16:52 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 6/7] iotests/129: Limit mirror job's buffer size Max Reitz
2021-01-13 16:03 ` Eric Blake
2021-01-13 17:02 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 7/7] iotests/129: Clean up pylint and mypy complaints Max Reitz
2021-01-13 16:04 ` Eric Blake
2021-01-13 14:31 ` [PATCH 0/7] iotests/129: Fix it Vladimir Sementsov-Ogievskiy
2021-01-13 15:19 ` Max Reitz
2021-01-13 15:29 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:38 ` Kevin Wolf
2021-01-13 14:59 ` Vladimir Sementsov-Ogievskiy
2021-01-13 15:26 ` Max Reitz
2021-01-13 15:43 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113154335.GC5928@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).