From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH v1 9/9] gitlab: move docs and tools build across from Travis
Date: Wed, 13 Jan 2021 16:32:24 +0000 [thread overview]
Message-ID: <20210113163224.GH1568240@redhat.com> (raw)
In-Reply-To: <8735z4n6kz.fsf@linaro.org>
On Wed, Jan 13, 2021 at 04:27:54PM +0000, Alex Bennée wrote:
>
> Daniel P. Berrangé <berrange@redhat.com> writes:
>
> > On Wed, Jan 13, 2021 at 03:14:08PM +0000, Alex Bennée wrote:
> >> While we are at it we might as well check the tag generation. For
> >> bonus points we run GNU globals htags into the public pages directory
> >> for publishing with the auto generated pages.
> >>
> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> ---
> >> .gitlab-ci.yml | 22 ++++++++++++++++------
> >> .travis.yml | 16 ----------------
> >> 2 files changed, 16 insertions(+), 22 deletions(-)
> >>
> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> >> index 4532f1718a..c07064a4f7 100644
> >> --- a/.gitlab-ci.yml
> >> +++ b/.gitlab-ci.yml
> >> @@ -79,7 +79,6 @@ build-system-ubuntu:
> >> TARGETS: aarch64-softmmu alpha-softmmu cris-softmmu hppa-softmmu
> >> moxie-softmmu microblazeel-softmmu mips64el-softmmu
> >> MAKE_CHECK_ARGS: check-build
> >> - CONFIGURE_ARGS: --enable-docs
> >> artifacts:
> >> expire_in: 2 days
> >> paths:
> >> @@ -111,7 +110,6 @@ build-system-debian:
> >> TARGETS: arm-softmmu avr-softmmu i386-softmmu mipsel-softmmu
> >> riscv64-softmmu sh4eb-softmmu sparc-softmmu xtensaeb-softmmu
> >> MAKE_CHECK_ARGS: check-build
> >> - CONFIGURE_ARGS: --enable-docs
> >> artifacts:
> >> expire_in: 2 days
> >> paths:
> >> @@ -126,6 +124,17 @@ check-system-debian:
> >> IMAGE: debian-amd64
> >> MAKE_CHECK_ARGS: check
> >>
> >> +build-tools-and-docs-debian:
> >> + <<: *native_build_job_definition
> >> + variables:
> >> + IMAGE: debian-amd64
> >> + MAKE_CHECK_ARGS: ctags gtags TAGS cscope
> >> + CONFIGURE_ARGS: --enable-docs --enable-tools
> >> + artifacts:
> >> + expire_in: 2 days
> >> + paths:
> >> + - build
> >
> > Do we actually need this job at all ?
> >
> > Assuming the depenedancies are in the dockerfile, then all the
> > build jobs will be testing docs and tools already, as meson will
> > auto enable it.
>
> I pondered making an explicit --disable-docs to save some run time but
> really this is providing a golden build of the docs which can tehn be
> deployed bypages.
Oh right I missed that subtle detail. I saw the separate pages job
but didn't realize this was a pre-req of it.
So with that in mind no objection.
> It also ensure the tag generation works for the various tag outputs -
> the GNU global output being used to also publish a HTML navigable
> version of the source tree.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-01-13 16:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 15:13 [PATCH v1 0/9] testing/next (tags!, more travis/shippable deprecation) Alex Bennée
2021-01-13 15:14 ` [PATCH v1 1/9] tests/docker: Remove Debian 9 remnant lines Alex Bennée
2021-01-13 15:14 ` [PATCH v1 2/9] Makefile: add GNU global tags support Alex Bennée
2021-01-13 15:14 ` [PATCH v1 3/9] shippable.yml: Remove jobs duplicated on Gitlab-CI Alex Bennée
2021-01-13 15:14 ` [PATCH v1 4/9] Add newline when generating Dockerfile Alex Bennée
2021-01-13 15:14 ` [PATCH v1 5/9] Makefile: wrap ctags in quiet-command calls Alex Bennée
2021-01-13 15:14 ` [PATCH v1 6/9] Makefile: wrap etags " Alex Bennée
2021-01-13 15:14 ` [PATCH v1 7/9] Makefile: wrap cscope " Alex Bennée
2021-01-13 15:14 ` [PATCH v1 8/9] docker: expand debian-amd64 image to include tag tools Alex Bennée
2021-01-13 15:14 ` [PATCH v1 9/9] gitlab: move docs and tools build across from Travis Alex Bennée
2021-01-13 15:35 ` Thomas Huth
2021-01-13 15:37 ` Daniel P. Berrangé
2021-01-13 15:46 ` Peter Maydell
2021-01-13 15:49 ` Daniel P. Berrangé
2021-01-13 16:27 ` Alex Bennée
2021-01-13 16:32 ` Daniel P. Berrangé [this message]
2021-01-13 19:25 ` Peter Maydell
2021-01-13 17:30 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113163224.GH1568240@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).